Fix issue with local storage in Android webview #9744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasmasuch
added
security-assessment-completed
4 tasks
kajarenc
approved these changes
Oct 28, 2024
edegp
pushed a commit
to edegp/streamlit
that referenced
this pull request
Jan 19, 2025
## Describe your changes The local storage in an Android WebView is only available when accessed via `window.localStorage` and not `localStorage` directly (see [here](https://stackoverflow.com/questions/5822256/error-web-console-uncaught-typeerror-cannot-call-method-getitem-of-null-at-h)). This PR makes sure that `window.localStorage` is used everywhere. This also adds a lint rule to prevent the usage of localStorage. ## GitHub Issue Link (if applicable) - Closes: streamlit#9740 ## Testing Plan - No logical changes and we cannot test usage of Android WebView easily. --- **Contribution License Agreement** By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
The local storage in an Android WebView is only available when accessed via
window.localStorageand notlocalStoragedirectly (see here). This PR makes sure thatwindow.localStorageis used everywhere.This also adds a lint rule to prevent the usage of localStorage.
GitHub Issue Link (if applicable)
Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.