Modernize markdown component #9736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasmasuch
added
security-assessment-completed
lukasmasuch
commented
Oct 25, 2024
Comment on lines
-615
to
-618
| throw Object.assign(new Error(), { | ||
| name: "Error parsing Markdown or HTML in this string", | ||
| message: <p>{source}</p>, | ||
| stack: null, |
Collaborator
Author
There was a problem hiding this comment.
This doesn't really seem necessary since the markdown component is already wrapped by two error boundaries, one around ReactMarkdown and another one in ElementNodeRenderer.
raethlein
approved these changes
Oct 28, 2024
edegp
pushed a commit
to edegp/streamlit
that referenced
this pull request
Jan 19, 2025
## Describe your changes Migrate the StreamlitMarkdown component from class-based to functional. ## Testing Plan - No logical changes, no tests required. --- **Contribution License Agreement** By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Migrate the StreamlitMarkdown component from class-based to functional.
Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.