Round pixels of calculated slider label pixel values #9735
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raethlein
added
security-assessment-completed
edegp
pushed a commit
to edegp/streamlit
that referenced
this pull request
Jan 19, 2025
## Describe your changes In streamlit#9494 a dynamic way was added to calculate the slider labels. It looks like the added snapshot tests are flaky (on Firefox). It looks like the pixel values can have a few decimal values which seems to shift the label slightly. ## GitHub Issue Link (if applicable) ## Testing Plan - Fix flaky tests, so change is covered by them. --- **Contribution License Agreement** By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
In #9494 a dynamic way was added to calculate the slider labels. It looks like the added snapshot tests are flaky (on Firefox). It looks like the pixel values can have a few decimal values which seems to shift the label slightly, as can be seen in the following diff screenshot that highlights the area that changed (as generated by our e2e snapshot tests):
GitHub Issue Link (if applicable)
Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.