Clean up global styles - part 2 #9714
Conversation
lukasmasuch
added
security-assessment-completed
There was a problem hiding this comment.
Change the link color to use the defined link color in our theme.
| export const StyledNoMicInputLearnMoreLink = styled.a(({ theme }) => ({ | ||
| color: theme.colors.linkText, | ||
| textDecoration: "underline", | ||
| })) |
There was a problem hiding this comment.
nit: I think we should probably have one top-level styled component to import these general ones from, as styled.a is not unique to the AudioInput. What do you think?
There was a problem hiding this comment.
There isn't really any other styled component yet with the exact same settings. Markdown uses the same settings but has CSS within the markdown-styled component. I will look into links again in a subsequent PR since there are a few more aspects to clean up around link stylings.
| // And undo these styles for placeholder links/named anchors (without href). | ||
| // It would be more straightforward to just use a[href] in previous block, but that | ||
| // causes specificity issues in many other styles that are too complex to fix. | ||
| // See https://github.com/twbs/bootstrap/issues/19402 | ||
| a:not([href]):not([class]) { | ||
| &, | ||
| &:hover { | ||
| color: inherit; | ||
| text-decoration: none; | ||
| } | ||
| } |
There was a problem hiding this comment.
This does not seem to be ported over to styled-components. Was this never used?
There was a problem hiding this comment.
I reverted this for now. I will look into this in a subsequent PR
| // Remove border from iframe | ||
| iframe { | ||
| border: 0; |
There was a problem hiding this comment.
iframe border none is already set in global styles above
## Describe your changes Cleans up our globalStyles.ts file by removing old & unused styles. This also refactors our markdown test and fixes audio input to use the link color defined in the theme instead of primary. ## Testing Plan - Update markdown e2e test --- **Contribution License Agreement** By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.
Describe your changes
Cleans up our globalStyles.ts file by removing old & unused styles. This also refactors our markdown test and fixes audio input to use the link color defined in the theme instead of primary.
Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.