[feat] Localize calendar week start date in st.date_input #9706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-bnisco
added
feature:st.date_input
sfc-gh-bnisco
force-pushed
the
bnisco/localize-calendar
branch
from
7abd6fb to
3d8baa8
Compare
sfc-gh-bnisco
changed the title
sfc-gh-bnisco
commented
Oct 29, 2024
frontend/lib/package.json
Outdated
Collaborator
Author
There was a problem hiding this comment.
note: This was previously an existing transitive dependency. I added it here to make it explicit / ensure the eslint rule about dependencies is happy.
sfc-gh-bnisco
force-pushed
the
bnisco/localize-calendar
branch
from
d8ff62d to
27f4805
Compare
edegp
pushed a commit
to edegp/streamlit
that referenced
this pull request
Jan 19, 2025
…9706) ## Describe your changes - `st.date_input` now understands the user's current locale and sets the start of the week based on it. ## GitHub Issue Link (if applicable) Closes streamlit#5215 ## Testing Plan - Explanation of why no additional tests are needed - Unit Tests (JS and/or Python) ✅ - E2E Tests ✅ - Any manual testing needed? --- **Contribution License Agreement** By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
st.date_inputnow understands the user's current locale and sets the start of the week based on it.GitHub Issue Link (if applicable)
Closes #5215
Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.