Update GUEST_READY message
#9702
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayagbarnes
added
security-assessment-completed
raethlein
reviewed
Oct 22, 2024
frontend/app/src/App.tsx
Outdated
| export interface Props { | ||
| screenCast: ScreenCastHOC | ||
| theme: ThemeManager | ||
| stExecTimestamp: number |
Collaborator
There was a problem hiding this comment.
nit: maybe it's a good idea to name this streamlitExecutionStartedAt to match the other name where it is passed to here. Also, streamlitExecutionStartedAt is a little bit more descriptive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Update the
GUEST_READYmessage payload to provide more information on Streamlit load timeSee JIRA ticket here
See prior approvals in PR #9207 - moved logic to this new PR (going into metrics feature branch instead)
Testing Plan