[fix] Ensure we utilize memo where we previously used PureComponent #9697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-bnisco
added
security-assessment-completed
lukasmasuch
approved these changes
Oct 21, 2024
frontend/lib/src/components/widgets/ColorPicker/ColorPicker.tsx
Outdated
Show resolved
Hide resolved
sfc-gh-bnisco
force-pushed
the
bnisco/modernize-memo
branch
from
889b2fc to
6cf43e1
Compare
sfc-gh-bnisco
force-pushed
the
bnisco/modernize-memo
branch
from
6cf43e1 to
a2a5f3e
Compare
lukasmasuch
approved these changes
Oct 23, 2024
edegp
pushed a commit
to edegp/streamlit
that referenced
this pull request
Jan 19, 2025
…treamlit#9697) ## Describe your changes - In some of my previous modernization PRs, I accidentally omitted a `React.memo` call for components that were previously using `PureComponent` - This PR puts `memo` calls where they should be to match prior behavior. - See the [React Docs](https://react.dev/reference/react/PureComponent#alternatives) on this ## GitHub Issue Link (if applicable) ## Testing Plan - Explanation of why no additional tests are needed ✅ - Existing tests cover this - Unit Tests (JS and/or Python) - E2E Tests - Any manual testing needed? --- **Contribution License Agreement** By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
React.memocall for components that were previously usingPureComponentmemocalls where they should be to match prior behavior.GitHub Issue Link (if applicable)
Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.