Skip to content

Rename SegmentMetricsManager #9610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mayagbarnes merged 1 commit into from
Oct 7, 2024
Merged

Rename SegmentMetricsManager #9610

mayagbarnes merged 1 commit into from
Oct 7, 2024

Conversation

@mayagbarnes
Copy link
Collaborator

@mayagbarnes mayagbarnes commented Oct 6, 2024 •
edited
Loading

Describe your changes

Initial renaming of SegmentMetricsManager class, files, & imports to MetricsManager - setting stage for telemetry migration.

Testing Plan

No new tests needed - just naming 😄

@mayagbarnes mayagbarnes changed the base branch from develop to metrics-migration October 6, 2024 01:38
@mayagbarnes mayagbarnes changed the title Rename SegmentMetricsManager Rename SegmentMetricsManager Oct 6, 2024
@mayagbarnes mayagbarnes added security-assessment-completed Security assessment has been completed for PR impact:internal PR changes only affect internal code change:chore PR contains maintenance or housekeeping change labels Oct 6, 2024
@mayagbarnes mayagbarnes marked this pull request as ready for review October 6, 2024 03:41
lukasmasuch
lukasmasuch approved these changes Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@lukasmasuch lukasmasuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mayagbarnes mayagbarnes merged commit c65ee7f into metrics-migration Oct 7, 2024
@mayagbarnes mayagbarnes deleted the metrics/rename branch October 7, 2024 18:31
mayagbarnes added a commit that referenced this pull request Oct 17, 2024
@mayagbarnes
Rename SegmentMetricsManager (#9610)
569b188 
Initial renaming of `SegmentMetricsManager` class, files, & imports to `MetricsManager` - setting stage for telemetry migration
mayagbarnes added a commit that referenced this pull request Oct 17, 2024
@mayagbarnes
Rename SegmentMetricsManager (#9610)
bac9298 
Initial renaming of `SegmentMetricsManager` class, files, & imports to `MetricsManager` - setting stage for telemetry migration
mayagbarnes added a commit that referenced this pull request Oct 21, 2024
@mayagbarnes
Rename SegmentMetricsManager (#9610)
0890cbf 
Initial renaming of `SegmentMetricsManager` class, files, & imports to `MetricsManager` - setting stage for telemetry migration
@mayagbarnes mayagbarnes mentioned this pull request Oct 24, 2024
Merged
mayagbarnes added a commit that referenced this pull request Oct 24, 2024
@mayagbarnes
Rename SegmentMetricsManager (#9610)
d4f9ffe 
Initial renaming of `SegmentMetricsManager` class, files, & imports to `MetricsManager` - setting stage for telemetry migration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukasmasuch lukasmasuch lukasmasuch approved these changes

Assignees

No one assigned

Labels

change:chore PR contains maintenance or housekeeping change impact:internal PR changes only affect internal code security-assessment-completed Security assessment has been completed for PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mayagbarnes @lukasmasuch