Merged
Conversation
tvst
approved these changes
Sep 12, 2019
frontend/src/index.jsx
Outdated
| ReactDOM.render( | ||
| <StyletronProvider value={engine}> | ||
| <BaseProvider theme={LightTheme}> | ||
| <BaseProvider theme={LightTheme} zIndex={102}> |
Contributor
There was a problem hiding this comment.
Can you use an SCSS variable for this?
See the z-index section in frontend/src/assets/css/variables.scss, which can be imported in TS via frontend/src/autogen/scssVariables.ts.
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Sep 13, 2019
* develop: Black + Pre-commit Hook (streamlit#81) Sidebar z-index bug (streamlit#96) Fix bug where message is not initialized in the spinner code (streamlit#101)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set z-index of BaseUI component layers to the z-index of Vega Lite popups