Update GUEST_READY message
#9207
Conversation
sfc-gh-pfinnigan
left a comment
sfc-gh-pfinnigan
left a comment
There was a problem hiding this comment.
This is looking like what we need. Thanks for adding!
mayagbarnes
changed the title
GUEST_READY messageGUEST_READY message
mayagbarnes
added
security-assessment-completed
raethlein
left a comment
raethlein
left a comment
There was a problem hiding this comment.
LGTM! I have left a comment about the naming of ReactLoad that I feel stronger about to avoid clashes, and a not-so-strong sanity-check about the date type. In general looks good 🙂
frontend/app/src/index.tsx
Outdated
| // Timestamp when React is loaded for GUEST_READY message | ||
| window.streamlitReactLoad = Date.now() |
There was a problem hiding this comment.
[nit] should this go even earlier - above line 29. Or even above the imports?
There was a problem hiding this comment.
streamlitExecutionStartedAt?
There was a problem hiding this comment.
This could be a prop passed to Themed app. But seems ok to use a window variable.
There was a problem hiding this comment.
If its possible to pass somewhere and not having it as a window variable would be even nicer (for testing, reasoning of code flow etc.) 🙂 👍
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Describe your changes
Update the
GUEST_READYmessage payload to provide more information on Streamlit load timeSee JIRA ticket here
Testing Plan