Merged
Conversation
tvst
approved these changes
Sep 11, 2019
Contributor
tvst
left a comment
tvst
left a comment
There was a problem hiding this comment.
I have reviewed every single file and they look great.
Makefile
Outdated
| # --ignore=E402,E128 \ | ||
| # --exclude=streamlit/proto/*_pb2.py \ | ||
| # $(PYTHON_MODULES) \ | ||
| # tests/ |
Contributor
There was a problem hiding this comment.
I assume all code produced by black is PEP8-compliant. In which case we don't need flake8 -- so why not just remove this?
Contributor
|
💃🎉🥳 |
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Sep 13, 2019
* develop: Black + Pre-commit Hook (streamlit#81) Sidebar z-index bug (streamlit#96) Fix bug where message is not initialized in the spinner code (streamlit#101)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Black - https://black.readthedocs.io/en/stable/
Git hooks with Husky - https://github.com/typicode/husky