Fix vertical spacing in Streamlit reports #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvst
commented
Aug 26, 2019
| type SimpleElement = ImmutableMap<string, any> | ||
| type Element = SimpleElement | BlockElement | ||
| interface BlockElement extends List<Element> { } | ||
| type StElement = SimpleElement | BlockElement |
Contributor
Author
There was a problem hiding this comment.
The name Element is confusing, since it is a type that already exists in JS. So I renamed this type to make it clear we're not talking about normal DOM elements.
tvst
commented
Aug 26, 2019
| class Block extends PureComponent<Props> { | ||
| private renderElements = (width: number): ReactNode[] => { | ||
| const elementsToRender = this.handleEmptyElements() | ||
| const elementsToRender = this.getElements() |
Contributor
Author
There was a problem hiding this comment.
Clearer function name.
tvst
commented
Aug 26, 2019
| const elementsToRender = this.handleEmptyElements() | ||
| const elementsToRender = this.getElements() | ||
|
|
||
| // Transform Streamlit elements into ReactNodes. |
Contributor
Author
There was a problem hiding this comment.
I broke this code into functions. No logic change.
tvst
commented
Aug 26, 2019
| } | ||
|
|
||
| private isStaleElement(element: SimpleElement): boolean { | ||
| private isElementStale(element: SimpleElement): boolean { |
tvst
commented
Aug 26, 2019
| .element-container { | ||
| display: block; | ||
| display: flex; | ||
| flex-direction: column; |
Contributor
Author
There was a problem hiding this comment.
This is the vertical spacing fix
tvst
commented
Aug 26, 2019
| const signatureHtml = <span className="doc-signature">{signature}</span> | ||
| const moduleHtml = <span className="doc-module" key="module">{module}.</span> | ||
| const nameHtml = <span className="doc-name" key="name">{name}</span> | ||
| const signatureHtml = <span className="doc-signature" key="signature">{signature}</span> |
Contributor
Author
There was a problem hiding this comment.
Address React warnings in the JS console.
…pected no return value
kantuni
reviewed
Aug 26, 2019
kantuni
approved these changes
Aug 26, 2019
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Aug 27, 2019
* develop: st.map() using deck_gl (streamlit#14) Adding support for if and for to magic (streamlit#12) Fix vertical spacing in Streamlit reports (streamlit#7) Fix streamlit#6: report should loads element by element (was broken since Sidebar PR) (streamlit#9)
4 tasks
sfc-gh-nbellante
added a commit
that referenced
this pull request
Oct 27, 2025
Removed customizable strings from ChatComposer to match ChatAudioRecorder. This pattern was over-engineering - no i18n system exists yet and it adds unnecessary complexity. Now uses hard-coded aria-labels directly. Also restored requestAnimationFrame in focusInput after tests proved it's necessary. RAF ensures focus happens after click events fully process, preventing race conditions when transitioning focus from buttons to input. Resolves PR #12834 comment #7 Addresses PR #12834 comment #4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Sidebar PR accidentally reduced the vertical spacing of Streamlit elements. This fixes that with a one-line CSS change, and then does some small refactors for Block-related readability.