Fix top padding on sidebar when embed is true #6565
Merged
+6
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-tszerszen
added
the
security-assessment-completed
sfc-gh-tszerszen
requested review from
jrieke,
sfc-gh-kbregula and
sfc-gh-mnowotka
sfc-gh-mnowotka
approved these changes
Apr 25, 2023
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Apr 25, 2023
* develop: Decouple MetricsManager from AppNode (streamlit#6557) Fix top padding on sidebar when embed is true (streamlit#6565) Add support for cell and column header tooltips in the dataframe component (streamlit#6561) Update dataframe column properties on frontend (streamlit#6554) Show warning for unsafe integer cells in `st.dataframe` (streamlit#6549) Add icon for editable columns in `st.data_editor` (streamlit#6550) Unify missing values to None in the returned datastructure by `st.data_editor`. (streamlit#6544) Clean up and reorganize element tree module (streamlit#6522) ESLint: use `--cache` flag (30x speedup!) (streamlit#6555) Replace `st.connection` with `st.experimental_connection` in docstring examples (streamlit#6553) Improve editing on touch devices for `st.data_editor` (streamlit#6548) Move pandas styler logic to dedicated module (streamlit#6543)
sfc-gh-kmcgrady
deleted the
fix-top-padding-on-sidebar-when-embed-is-true
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Context
Please describe the project or issue background here
What kind of change does this PR introduce?
🧠 Description of Changes
This PR closes Issue-#6057. It removes
2pxempty space between sidebar and browser bar, when?embed=truequery param is enabled.Add bullet points summarizing your changes here
Revised:
Insert screenshot of your updated UI/code here
Notice there is no empty space between sidebar and browser topbar
Current:
Notice small 2px empty space between sidebar and browser topbar, this should disappear after this PR is merged
Insert screenshot of existing UI/code here
🧪 Testing Done
🌐 References
Does this depend on other work, documents, or tickets?
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.