Issue 1204: Graphs using Vega-Lite#56
Merged
arraydude merged 51 commits intostreamlit:developfrom Sep 23, 2019
Merged
Conversation
… 1204-vegaLite # Conflicts: # frontend/cypress/integration/examples/core/area_chart.spec.ts # frontend/cypress/integration/examples/core/bar_chart.spec.ts # frontend/cypress/integration/examples/core/line_chart.spec.ts
kantuni
reviewed
Sep 9, 2019
kantuni
reviewed
Sep 9, 2019
Collaborator
kantuni
left a comment
kantuni
left a comment
There was a problem hiding this comment.
LGTM. Only style issues.
tvst
reviewed
Sep 11, 2019
tvst
reviewed
Sep 11, 2019
tvst
reviewed
Sep 11, 2019
tvst
reviewed
Sep 11, 2019
tvst
suggested changes
Sep 20, 2019
Contributor
There was a problem hiding this comment.
I don't think this includes the changes we talked about. This code was going to move to DeltaGenerator, and we also needed to add this to add_rows.
Contributor
Author
There was a problem hiding this comment.
Inside _enqueue_new_element_delta the data is already transformed and i'm needing the original one , that's why i did not move that .
The logics for add_rows is added
domoritz
changed the title
… 1204-vegaLite # Conflicts: # examples/mnist-cnn.py # frontend/cypress/snapshots/linux/2x/vega_lite_chart.spec.ts/st.vega_lite_chart -- supports different ways to get the same plot.snap.png
tvst
reviewed
Sep 23, 2019
examples/mnist-cnn.py
Outdated
| def on_batch_end(self, batch, logs=None): | ||
| rows = pd.DataFrame( | ||
| [[logs["loss"], logs["accuracy"]]], columns=["loss", "accuracy"]) | ||
| [[logs["loss"], logs["acc"]]], columns=["loss", "acc"]) |
Contributor
There was a problem hiding this comment.
Change back to "accuracy' and upgrade your Keras to the latest version. They changed this, apparently.
pip install keras --upgrade
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Sep 25, 2019
# By Jonathan Rhone (3) and others # Via GitHub * develop: Text changes in ☰ menu and several CLI prompts (streamlit#180) add format option for slider widget and return texts for display values (streamlit#154) Merge ForwardMsg caching into develop (streamlit#178) e2e test for magic (streamlit#172) Bart example update (streamlit#179) Pedantic CircleCI cleanup (streamlit#174) Fix overwriting elements in the sidebar (streamlit#181) update vega lite chart snapshot (streamlit#183) Stop react-markdown from converting "[foo]" to a link. (streamlit#151) Issue 1204: Graphs using Vega-Lite (streamlit#56) Removing uber demo from streamlit repo (streamlit#159) # Conflicts: # lib/streamlit/DeltaGenerator.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes streamlit/streamlit-old-private#1204
delta_typepropertyadd_rowsmethod transforms the structure if it is needed depending on thedelta_type