Ignore a sometimes-redundant cast #4761
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdonato
force-pushed
the
ignore-redundant-cast
branch
from
bdbddf6 to
1e9e82a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Context
A new version of
numpythat was released ~2 hours ago apparently made some improvementsto type inference when indexing into an NDArray. This caused
mypyto get upset with us over whatwas previously a necessary cast that is now redundant. We fixed this by adding a
# type: ignore[redundant-cast]so that we can support both older and newernumpyversions.Note that we also had to turn off
warn_unused_ignoressince the ignore is sometimes used andsometimes not depending on the Python version, but I don't see a good way around this.
What kind of change does this PR introduce?