Skip to content

Allow columns to be rendered to create spacing#4217

Merged
kmcgrady merged 6 commits intostreamlit:developfrom
kmcgrady:fix/columns
Dec 27, 2021
Merged

Allow columns to be rendered to create spacing#4217
kmcgrady merged 6 commits intostreamlit:developfrom
kmcgrady:fix/columns

Conversation

@kmcgrady
Copy link
Copy Markdown
Collaborator

@kmcgrady kmcgrady commented Dec 27, 2021

📚 Context

A bug was introduced with 1.3.0 where columns were not rendered if there were no children in them. This change undoes that by ensuring the column renders as expected.

  • What kind of change does this PR introduce?

    • Bugfix

🧠 Description of Changes

  • Change columns to be included regardless of empty state

🧪 Testing Done

  • Screenshots included
  • Added/Updated unit tests
  • Added/Updated e2e tests

🌐 References


Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@kmcgrady kmcgrady merged commit a404398 into streamlit:develop Dec 27, 2021
@kmcgrady kmcgrady deleted the fix/columns branch December 27, 2021 23:02
tconkling added a commit to tconkling/streamlit that referenced this pull request Jan 3, 2022
* develop:
  Fix hello demo type annotation (streamlit#4228)
  Release 1.3.1 (streamlit#4220)
  Improve beta_ deprecation message (streamlit#4219)
  Changing Image Algorithm to Bilinear (streamlit#4159)
  Allow columns to be rendered to create spacing (streamlit#4217)
  Fix issue with hidden balloons (approach 2) (streamlit#4204)
  Fix mypy errors from 0.930 release (streamlit#4218)
  Fix/selectbox typings (streamlit#4194)
  Support running tests locally on Apple Silicon (streamlit#4185)
  Stop screencast recorder when user removes permission / stops using browser button. (streamlit#4180)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1.3.0 bug - Empty columns are not respected in layouts

3 participants