Fix issue with hidden balloons (approach 2)#4204
Fix issue with hidden balloons (approach 2)#4204kmcgrady merged 16 commits intostreamlit:developfrom
Conversation
lukasmasuch
changed the title
lib/Pipfile
Outdated
| botocore = ">=1.13.44" | ||
| hypothesis = ">=6.17.4" | ||
| mypy = ">=0.910" | ||
| mypy = ">=0.910, <0.930" |
There was a problem hiding this comment.
I don't think we should do this (in fact, if anything, we should pin mypy = ">=0.930")
There was a problem hiding this comment.
That's was just a test if my build or mypy is broken. And as it turns out, mypy 0.930 (which was released a few hours ago) breaks our build pipelines :(
There was a problem hiding this comment.
There was a problem hiding this comment.
I think it may just be necessary to pull in the latest changes from develop, since I believe #4191 fixed this
There was a problem hiding this comment.
I will try that. However, the builds went fine yesterday and those issues only appeared after mypy 0.930 got released. So, I'm assuming there are additional issues 😬
There was a problem hiding this comment.
Actually, the fixes from #4191 are already included in this branch.
There was a problem hiding this comment.
Ah, #4191 fixed the issues that appeared with mypy 0.920
I didn't realize this was a new set of issues that appeared with the release of 0.930 😬
There was a problem hiding this comment.
Annoying!
It looks like all these issues are in the legacy_caching/hashing.py file - as a stopgap, we could add # type: ignore to the top of that file, along with a TODO to investigate after the break. (#core-platform can be in charge of fixing this issue.)
There was a problem hiding this comment.
We got a solution with #4218 that fixes with the latest mypy. I've merged it in this one.
Co-authored-by: Ken McGrady <[email protected]>
* develop: Fix hello demo type annotation (streamlit#4228) Release 1.3.1 (streamlit#4220) Improve beta_ deprecation message (streamlit#4219) Changing Image Algorithm to Bilinear (streamlit#4159) Allow columns to be rendered to create spacing (streamlit#4217) Fix issue with hidden balloons (approach 2) (streamlit#4204) Fix mypy errors from 0.930 release (streamlit#4218) Fix/selectbox typings (streamlit#4194) Support running tests locally on Apple Silicon (streamlit#4185) Stop screencast recorder when user removes permission / stops using browser button. (streamlit#4180)
4 participants
📚 Context
The
Block.tsxrefactoring applies adisplay: noneto the element containers ofemptyandballoonselements. The reason is to prevent thegapof the parent flexbox. However, theballoonelement is never shown on the frontend due todisplay: none. This PR applies negative bottom margin to balloons in the same size of the gap to prevent the gap. With this workaround, we can render theballoonselement.This PR also removes the
isHiddenflag, since it is not anymore needed as abstraction sinceemptyandballoonsare now treated differently.What kind of change does this PR introduce?
🧪 Testing Done
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.