Merged
Conversation
Previously, these functions returning sets was considered valid by mypy and the python docs, but now they are expected to be actual view objects. Unfortunately the constructors for the view objects assume your class is a dumb wrapper around a dict, and so don't work correctly with `WStates` for items/values (because it relies on you calling `__getitem__`), and also don't work well with `SessionState` merging and key translating several dicts. So we will mostly ignore this, except for keys view for `WStates`, which should work fine as a `KeysView`.
vdonato
approved these changes
Dec 17, 2021
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Dec 20, 2021
* develop: Update error message for redacted exception (streamlit#4200) Release 1.3.0 (streamlit#4192) Wait for enough elements to load in flaky e2e tests (streamlit#4193) Ignore type errors introduced by mypy 0.920 (streamlit#4191) Change st.plotly docstring to fix docs rendering (streamlit#4182) Fix recursion error in repr method of report thread (streamlit#4176)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.