Skip to content

Support running (most) tests locally on Apple Silicon#4185

Merged
vdonato merged 1 commit intostreamlit:developfrom
vdonato:more-m1-dev-compat
Dec 20, 2021
Merged

Support running (most) tests locally on Apple Silicon#4185
vdonato merged 1 commit intostreamlit:developfrom
vdonato:more-m1-dev-compat

Conversation

@vdonato
Copy link
Copy Markdown
Collaborator

@vdonato vdonato commented Dec 16, 2021

📚 Context

We currently mostly-support development on M1 Macs with the exception of being
able to run Python tests locally. This is because tensorflow's official
pre-built binaries do not currently include releases supporting Apple Silicon.

We recently added some code to avoid installing tensorflow in environments
running Python 3.10 (as tensorflow doesn't support 3.10 yet), so it wasn't
much extra effort from there to also avoid installing those dependencies on M1
machines.

  • What kind of change does this PR introduce?

    • Other, please describe: Improved Apple Silicon dev env support

🧠 Description of Changes

  • Avoid installing tensorflow and related dependencies on M1 Macs
  • Rename a few files to no longer reference Python 3.9

@vdonato vdonato requested a review from tconkling December 16, 2021 01:04
Copy link
Copy Markdown
Contributor

@tconkling tconkling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff!

@vdonato vdonato merged commit e2d183c into streamlit:develop Dec 20, 2021
@vdonato vdonato deleted the more-m1-dev-compat branch December 20, 2021 21:35
tconkling added a commit to tconkling/streamlit that referenced this pull request Jan 3, 2022
* develop:
  Fix hello demo type annotation (streamlit#4228)
  Release 1.3.1 (streamlit#4220)
  Improve beta_ deprecation message (streamlit#4219)
  Changing Image Algorithm to Bilinear (streamlit#4159)
  Allow columns to be rendered to create spacing (streamlit#4217)
  Fix issue with hidden balloons (approach 2) (streamlit#4204)
  Fix mypy errors from 0.930 release (streamlit#4218)
  Fix/selectbox typings (streamlit#4194)
  Support running tests locally on Apple Silicon (streamlit#4185)
  Stop screencast recorder when user removes permission / stops using browser button. (streamlit#4180)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants