Stop recording screencast when user clicks "stop" using browser button#4180
Merged
tvst merged 1 commit intostreamlit:developfrom Dec 20, 2021
Merged
Stop recording screencast when user clicks "stop" using browser button#4180tvst merged 1 commit intostreamlit:developfrom
tvst merged 1 commit intostreamlit:developfrom
Conversation
Contributor
Author
|
Controversial part: no tests. But the code had no tests before, is hard to test without testing the exact implementation, and is not in the app's critical path. I leave it up to you whether this is mergeable 😆 |
kajarenc
approved these changes
Dec 16, 2021
Contributor
|
LGTM 👍 |
Contributor
|
@tvst We reviewed and tested this PR in a mob programming session with the almost whole team, and the general opinion is that it is quite difficult to test the behavior of screencast recording, which is also a good argument in favor of the decision to remove this feature. (it seems that Cypress has no available primitives for this). So this is not only my approval but also the consolidated opinion of the team, feel free to merge! |
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Jan 3, 2022
* develop: Fix hello demo type annotation (streamlit#4228) Release 1.3.1 (streamlit#4220) Improve beta_ deprecation message (streamlit#4219) Changing Image Algorithm to Bilinear (streamlit#4159) Allow columns to be rendered to create spacing (streamlit#4217) Fix issue with hidden balloons (approach 2) (streamlit#4204) Fix mypy errors from 0.930 release (streamlit#4218) Fix/selectbox typings (streamlit#4194) Support running tests locally on Apple Silicon (streamlit#4185) Stop screencast recorder when user removes permission / stops using browser button. (streamlit#4180)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Context
Today there's the "Record a screencast" feature has a bug where it becomes impossible to stop recording when you do the following:
This PR fixes that.
What kind of change does this PR introduce?
🧠 Description of Changes
Add
onstopandonerrorhandlers to theMediaRecorderobject.Upon an error/stop even, tell the UI's state machine that we're no longer recording.
🧪 Testing Done
Screenshots includedn/aAdded/Updated unit testsThis code is not currently tested or easily testable. Just landing a quick fix. Hopefully this is OK?Added/Updated e2e testsn/a🌐 References
Does this depend on other work, documents, or tickets?
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.