-
Notifications
You must be signed in to change notification settings - Fork 4k
Remove incorrect background of code inside error messages #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvst
approved these changes
Aug 24, 2019
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Aug 27, 2019
* develop: Fix streamlit#1230: OSError not caught when writing cache to disk (streamlit#8) Improve caching code (streamlit#2) Remove incorrect background of code inside error messages (streamlit#4) Fix line number in error message (streamlit#3) Update README.md Implement Caching object to support running code blocks only once (streamlit#1) Update README.md Add font licenses to NOTICE (streamlit#1267) Clean up repo for open source release. Remove unecessary folders. (streamlit#1266) Fix st.cache (streamlit#1273) Close streamlit#1092 (streamlit#1270) Change license header in variables.scss so it's compatible with scss-to-json. (streamlit#1268) Sidebar (streamlit#1224) Add Apache license and update all license headers (streamlit#1265) Handling objects with empty docs in st.help (streamlit#1261) Enhance Mochawesome report with screenshots (streamlit#1263) Add LICENSES file (streamlit#1262)
tvst
added a commit
that referenced
this pull request
Aug 26, 2021
* Streamlit pink -> red70, normal text -> gray85 * Update font sizes * Change fonts to Source Sans/Serif/Code Pro * Add font files to Streamlit * Update test snapshots * Streamlit pink -> red70, normal text -> gray85 * Update font sizes * Refactor labels and remove when nullsy (to fix settings dialog) * Add snapshot tests (but no spapshots yet) * Move WidgetLabel to its own file
1 task
sfc-gh-lwilby
added a commit
that referenced
this pull request
Oct 19, 2025
…ions Addresses three suggestions from PR #12807 review: 1. Simplify test cases (suggestion #2) - Reduced from 9 parameterized tests to 3 focused tests - Removed fragment and expander contexts (regression only in containers) - Eliminated parameterization that made test app hard to read - Simple, clear structure with named containers 2. Add deterministic width assertions (suggestion #3) - stretch: Container width=600, expect ~580-600px (allows padding) - content: Figure 6.4in @ 100 DPI = 640px, expect ~620-640px - pixel: Explicit width=500, expect ~480-500px - More stable than arbitrary >200px threshold 3. Clean up unnecessary comments (suggestion #4) - Removed comments that just describe next line - Kept meaningful comments explaining test logic and expectations - Improved readability Test structure: - 3 regression tests in containers only - Specific figure size (6.4in x 4.8in at 100 DPI) - Known container width for stretch test - Deterministic assertions with reasonable margins Note: Suggestion #1 (use_container_width check) addressed with explanation in PR comment - current logic is correct for the new widthConfig system.
sfc-gh-lwilby
added a commit
that referenced
this pull request
Oct 22, 2025
…ions Addresses three suggestions from PR #12807 review: 1. Simplify test cases (suggestion #2) - Reduced from 9 parameterized tests to 3 focused tests - Removed fragment and expander contexts (regression only in containers) - Eliminated parameterization that made test app hard to read - Simple, clear structure with named containers 2. Add deterministic width assertions (suggestion #3) - stretch: Container width=600, expect ~580-600px (allows padding) - content: Figure 6.4in @ 100 DPI = 640px, expect ~620-640px - pixel: Explicit width=500, expect ~480-500px - More stable than arbitrary >200px threshold 3. Clean up unnecessary comments (suggestion #4) - Removed comments that just describe next line - Kept meaningful comments explaining test logic and expectations - Improved readability Test structure: - 3 regression tests in containers only - Specific figure size (6.4in x 4.8in at 100 DPI) - Known container width for stretch test - Deterministic assertions with reasonable margins Note: Suggestion #1 (use_container_width check) addressed with explanation in PR comment - current logic is correct for the new widthConfig system.
sfc-gh-nbellante
added a commit
that referenced
this pull request
Oct 27, 2025
Removed customizable strings from ChatComposer to match ChatAudioRecorder. This pattern was over-engineering - no i18n system exists yet and it adds unnecessary complexity. Now uses hard-coded aria-labels directly. Also restored requestAnimationFrame in focusInput after tests proved it's necessary. RAF ensures focus happens after click events fully process, preventing race conditions when transitioning focus from buttons to input. Resolves PR #12834 comment #7 Addresses PR #12834 comment #4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After: