UI tweaks #4: widget labels #3680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvst
force-pushed
the
feature/ui-4-labels
branch
from
148f9fd to
31ac929
Compare
kmcgrady
reviewed
Aug 18, 2021
Collaborator
kmcgrady
left a comment
kmcgrady
left a comment
There was a problem hiding this comment.
I might be a little confused here. Let me know if I am missing something.
tvst
force-pushed
the
feature/ui-3-fontfamily
branch
from
fa5616f to
cf326aa
Compare
tvst
force-pushed
the
feature/ui-4-labels
branch
from
31ac929 to
8d52eca
Compare
kmcgrady
approved these changes
Aug 26, 2021
tvst
force-pushed
the
feature/ui-3-fontfamily
branch
from
7a7a9a2 to
732e2ac
Compare
tvst
force-pushed
the
feature/ui-4-labels
branch
from
861381d to
1318791
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Breaking up #3642 into multiple PRs)
""does occupy space, just like today.NOTE: Screenshot tests coming after first round of reviews. Don't want to generate and re-generate as more reviews come in 😅
NOTE #2: Note the base branch for this PR. I'm basing it on the previous UI tweaks PR so the diff is easier to read. The idea is to merge in order.