-
Notifications
You must be signed in to change notification settings - Fork 4k
Fix vertical align #3317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix vertical align #3317
Conversation
Remove renderLabel method and update selectbox label stucture to use that of similarly sized widgets like text_input
Update StyledWidgetLabel's CSS properties to ensure that a widget's vertical position remains the same with or without a label
# By Ken McGrady (19) and others # Via GitHub (9) and others * develop: (96 commits) st.form: clear_on_submit (streamlit#3287) Init test variables in beforeEach Init test variables in beforeEach Add database tutorials to docs (streamlit#3272) update contact email to support (streamlit#3282) Better typing Remove dummy script Add testing and some comments Fix the bug, don't love the solution Improve test name Add script for testing Fix test after merge Make sure selected options aren't visible in the dropdown Widget test cleanup (streamlit#3286) Add test for the fuzzy filter Import filter function from another component Remove tag from PR template (streamlit#3284) Add test req version bound for TF to fix tests (streamlit#3266) pin click to < 8.0 (streamlit#3256) Up version to 0.82.0 ... # Conflicts: # frontend/src/components/shared/Dropdown/Selectbox.test.tsx
b1b6b56 to
6ae09c4
Compare
|
@tvst is taking a look at the CSS changes today. If he's cool with them, I'll update the failing Cypress snapshots. |
|
Found some vertical alignment issues which possibly predated this PR: See code here: 50b91a4 |
* develop: Fix ReST vs Markdown typos and update conda docs link (streamlit#3371) update requirements file documentation (streamlit#3372) Fix a peculiar issue with yarn start (streamlit#3374) Remove unused mocha dependency (streamlit#3326) Update `typed-signals` to 2.2.0 (streamlit#3325) update classnames lib to 2.3.1 (streamlit#3331) Update DOMPurify to 2.2.8 (the latest) (streamlit#3327) Update protobufjs to 6.11.2 (streamlit#3329) Update react to latest point release (streamlit#3328) Update @craco/craco to 6.1.2 (streamlit#3324) Update testing-library to the latest (streamlit#3330) Update clipboardjs to 2.0.8 (streamlit#3332) Update JSON5 to 2.2.0 (streamlit#3333) * Add explanatory comment for naive email validation (streamlit#3349) ComponentInstance: cancel the componentReadyWarningTimer on unmount (streamlit#3316) Don't unmount iframe after custom component timeout (streamlit#3315)
…ical-align * commit '50b91a4a18ce620f4e0e980f40f6f5b2503e1d33': Fix vertical alignment of tooltip icon
|
Thanks, Thiago! (I've merged @tvst's changes in here.) |
|
This PR introduces some subtle changes to the way the ColorPicker border renders - @tvst, is this cool/intentional? |
|
@tconkling Probably out of the scope of this PR, but is there some reason why we don't take the same approach with For |
I don't think there's a good reason - just different people touching the files at different times. Might be worth a drive-by cleanup down the line. |
* develop: (21 commits) config.py: types + cleanup (streamlit#3393) add faq item regarding use of PYTHONPATH (streamlit#3391) Fix vertical align (streamlit#3317) Create visualize_rent_prices_with_Streamlit.md (streamlit#3193) Update app resource limits (streamlit#3384) Bump dns-packet from 1.3.1 to 1.3.4 in /frontend (streamlit#3341) Bump ws from 6.2.1 to 6.2.2 in /frontend (streamlit#3358) Fix ReST vs Markdown typos and update conda docs link (streamlit#3371) update requirements file documentation (streamlit#3372) Fix a peculiar issue with yarn start (streamlit#3374) Remove unused mocha dependency (streamlit#3326) Update `typed-signals` to 2.2.0 (streamlit#3325) update classnames lib to 2.3.1 (streamlit#3331) Update DOMPurify to 2.2.8 (the latest) (streamlit#3327) Update protobufjs to 6.11.2 (streamlit#3329) Update react to latest point release (streamlit#3328) Update @craco/craco to 6.1.2 (streamlit#3324) Update testing-library to the latest (streamlit#3330) Update clipboardjs to 2.0.8 (streamlit#3332) Update JSON5 to 2.2.0 (streamlit#3333) ...


Updating PR from @hyerrakalva (#3176)
Fixes #3220
Original PR description:
Issue: #3071
Description: This PR fixes visual inconsistencies that may occur when creating widgets in a
beta_columnscontainer without specifying a label.Selectboxcomponent's label+help element structure to make it vertically align properly with other widget types when all widgets in abeta_columnscontainer are unlabeledSelectbox.test.tsxto ensure that a label element always exists within aSelectboxcomponent, even if a label is not specified, for accessibility purposesStyledWidgetLabelcomponent to ensure that widgets inbeta_columnscontainer are vertically aligned when there is a combination of labeled & unlabeled widgets