Don't unmount iframe after custom component timeout #3315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tWarning * lekev/develop: Fix: re-ender iframe after component timeout
kantuni
approved these changes
May 25, 2021
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Jun 7, 2021
* develop: Fix ReST vs Markdown typos and update conda docs link (streamlit#3371) update requirements file documentation (streamlit#3372) Fix a peculiar issue with yarn start (streamlit#3374) Remove unused mocha dependency (streamlit#3326) Update `typed-signals` to 2.2.0 (streamlit#3325) update classnames lib to 2.3.1 (streamlit#3331) Update DOMPurify to 2.2.8 (the latest) (streamlit#3327) Update protobufjs to 6.11.2 (streamlit#3329) Update react to latest point release (streamlit#3328) Update @craco/craco to 6.1.2 (streamlit#3324) Update testing-library to the latest (streamlit#3330) Update clipboardjs to 2.0.8 (streamlit#3332) Update JSON5 to 2.2.0 (streamlit#3333) * Add explanatory comment for naive email validation (streamlit#3349) ComponentInstance: cancel the componentReadyWarningTimer on unmount (streamlit#3316) Don't unmount iframe after custom component timeout (streamlit#3315)
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently remove a Custom Component's iframe from the render output when it times out, which means the component has no way of belatedly saying "hey I've finally mounted".
This was discovered and fixed by https://github.com/lekev in #3306. I've just added some additional cleanup.