Skip to content

Conversation

@kmcgrady
Copy link
Collaborator

No description provided.

@kmcgrady kmcgrady requested a review from a team May 17, 2021 17:34
Copy link
Contributor

@trajamsmith trajamsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I don't know the reasoning behind the change 🤷‍♂️

@kmcgrady kmcgrady merged commit 2f4758c into streamlit:develop May 17, 2021
@kmcgrady kmcgrady deleted the pr-fix branch May 17, 2021 17:43
tconkling added a commit to tconkling/streamlit that referenced this pull request May 17, 2021
* develop:
  Remove tag from PR template (streamlit#3284)
  Add test req version bound for TF to fix tests (streamlit#3266)
  Add support for toml syntax highlighting in code blocks (streamlit#3140)
  Don't allow config.get_option to be called on file import (streamlit#3235)
  pin click to < 8.0 (streamlit#3256)
  Random cleanup: docstrings + type-safety (streamlit#3252)
  "setWidgetValue" -> "commitWidgetValue" (streamlit#3253)
tconkling added a commit that referenced this pull request May 18, 2021
* develop: (75 commits)
  Remove tag from PR template (#3284)
  Add test req version bound for TF to fix tests (#3266)
  pin click to < 8.0 (#3256)
  Up version to 0.82.0
  Update change log
  Add support for toml syntax highlighting in code blocks (#3140)
  Don't allow config.get_option to be called on file import (#3235)
  pin click to < 8.0 (#3256)
  Random cleanup: docstrings + type-safety (#3252)
  "setWidgetValue" -> "commitWidgetValue" (#3253)
  Fix inactive DatePicker if the date value is 10 years earlier (#3241)
  Upgrade trim to 0.0.3 or later (#3250)
  Manually name all snapshots and generate missing ones (#3205)
  Fix Video Recorded modal dialog width (#3226)
  Bump handlebars from 4.7.6 to 4.7.7 in /frontend (#3238)
  Bump hosted-git-info from 2.8.8 to 2.8.9 in /frontend (#3234)
  Bump lodash from 4.17.20 to 4.17.21 in /frontend (#3233)
  Bump ua-parser-js from 0.7.23 to 0.7.28 in /frontend (#3231)
  Update FAQs with supported browsers (#3225)
  Update copyright date (#3228)
  ...
kajarenc added a commit that referenced this pull request May 19, 2021
* Add container/block type `Card`

* Update change log

* Up version to 0.82.0

* pin click to < 8.0 (#3256)

Click 8.0 has breaking API changes

* Use `margin` and `padding` instead of `marginTop`, ... and `paddingTop` ...

* Remove tag from PR template (#3284)

* * Prevent nested cards

Co-authored-by: Ken McGrady <[email protected]>
Co-authored-by: Tim Conkling <[email protected]>
Co-authored-by: Ken McGrady <[email protected]>
tconkling added a commit to tconkling/streamlit that referenced this pull request May 25, 2021
# By Ken McGrady (19) and others
# Via GitHub (9) and others
* develop: (96 commits)
  st.form: clear_on_submit (streamlit#3287)
  Init test variables in beforeEach
  Init test variables in beforeEach
  Add database tutorials to docs (streamlit#3272)
  update contact email to support (streamlit#3282)
  Better typing
  Remove dummy script
  Add testing and some comments
  Fix the bug, don't love the solution
  Improve test name
  Add script for testing
  Fix test after merge
  Make sure selected options aren't visible in the dropdown
  Widget test cleanup (streamlit#3286)
  Add test for the fuzzy filter
  Import filter function from another component
  Remove tag from PR template (streamlit#3284)
  Add test req version bound for TF to fix tests (streamlit#3266)
  pin click to < 8.0 (streamlit#3256)
  Up version to 0.82.0
  ...

# Conflicts:
#	frontend/src/components/shared/Dropdown/Selectbox.test.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants