Skip to content

Create visualize_rent_prices_with_Streamlit.md #3193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
randyzwitch merged 4 commits into from
Jun 8, 2021
Merged

Create visualize_rent_prices_with_Streamlit.md #3193

randyzwitch merged 4 commits into from
Jun 8, 2021

Conversation

@sixhobbits
Copy link
Contributor

@sixhobbits sixhobbits commented Apr 29, 2021 •
edited
Loading

Issue: N/A

Description:

We are enjoying Streamlit and we built a basic app and tutorial that extends the current data explorer example with some useful features that others can adapt.

We (https://ritza.co) are a startup that helps companies produce technical articles, tutorials, and documentation for developers. Let us know if you need any help with the Streamlit docs or more example content and we would love to work with you!

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@randyzwitch
Copy link
Contributor

randyzwitch commented May 5, 2021

Hi @sixhobbits, thanks for your contribution. Before this can be merged, there are several issues:

  1. The documentation does not build, according to our embedded ReadtheDocs check
  2. There are several typos in the example
  3. The links to the pictures are external to Streamlit-owned repositories. Please move the pictures into the streamlit /docs directory in the appropriate location.
  4. For the section where you mention "Streamlit includes its own simpler visualization library", it is more correct to say that we provide convenience functions around Altair. Streamlit isn't building our own visualizations.

Note that by accepting this pull request, we are doing so as an open-source contribution, not as an agreement to pay you or your company for writing a tutorial.

Best,
Randy

@randyzwitch randyzwitch added the status:awaiting-user-response Issue requires clarification from submitter label May 10, 2021
@sixhobbits
Copy link
Contributor Author

sixhobbits commented May 13, 2021 •
edited
Loading

Thanks for the response and feedback, Randy.

1. The documentation does not build, according to our embedded ReadtheDocs check

Fixed. It seems having the string `$` in text was the issue in case that is interesting.

2. There are several typos in the example

We fixed several typos.

3. The links to the pictures are external to Streamlit-owned repositories. Please move the pictures into the streamlit /docs directory in the appropriate location.

Images moved into a local directory.

4. For the section where you mention "Streamlit includes its own simpler visualization library", it is more correct to say that we provide convenience functions around Altair. Streamlit isn't building our own visualizations.

Revised this sentence.

Note that by accepting this pull request, we are doing so as an open-source contribution, not as an agreement to pay you or your company for writing a tutorial.

Of course :) We love Streamlit and sorry if the ad for our services was too commercial for the spirit of open source.

@vdonato vdonato removed the status:awaiting-user-response Issue requires clarification from submitter label May 14, 2021
@stale
Copy link

stale bot commented May 29, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 29, 2021
@stale stale bot closed this May 30, 2021
@sixhobbits
Copy link
Contributor Author

sixhobbits commented May 31, 2021

@randyzwitch - given that we addressed all of your feedback, let us know if this is of any use to you now.

@randyzwitch randyzwitch reopened this Jun 1, 2021
@stale stale bot removed the stale label Jun 1, 2021
@randyzwitch randyzwitch merged commit c268327 into streamlit:develop Jun 8, 2021
tconkling added a commit to tconkling/streamlit that referenced this pull request Jun 9, 2021
@tconkling
Merge branch 'develop' into tim/RemoveWhichBrowser
37fd7bc 
* develop: (21 commits)
  config.py: types + cleanup (streamlit#3393)
  add faq item regarding use of PYTHONPATH (streamlit#3391)
  Fix vertical align (streamlit#3317)
  Create visualize_rent_prices_with_Streamlit.md (streamlit#3193)
  Update app resource limits (streamlit#3384)
  Bump dns-packet from 1.3.1 to 1.3.4 in /frontend (streamlit#3341)
  Bump ws from 6.2.1 to 6.2.2 in /frontend (streamlit#3358)
  Fix ReST vs Markdown typos and update conda docs link (streamlit#3371)
  update requirements file documentation (streamlit#3372)
  Fix a peculiar issue with yarn start (streamlit#3374)
  Remove unused mocha dependency (streamlit#3326)
  Update `typed-signals` to 2.2.0 (streamlit#3325)
  update classnames lib to 2.3.1 (streamlit#3331)
  Update DOMPurify to 2.2.8 (the latest) (streamlit#3327)
  Update protobufjs to 6.11.2 (streamlit#3329)
  Update react to latest point release (streamlit#3328)
  Update @craco/craco to 6.1.2 (streamlit#3324)
  Update testing-library to the latest (streamlit#3330)
  Update clipboardjs to 2.0.8 (streamlit#3332)
  Update JSON5 to 2.2.0 (streamlit#3333)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mesmith027 mesmith027 Awaiting requested review from mesmith027

1 more reviewer

@randyzwitch randyzwitch randyzwitch approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sixhobbits @randyzwitch @vdonato