Fix Markdown Anchors bugs #3127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 13, 2021 11:13
ghost
self-requested a review
vdonato
reviewed
Apr 13, 2021
Collaborator
vdonato
left a comment
vdonato
left a comment
There was a problem hiding this comment.
I think we'll want to add an e2e test in the st_markdown script that checks that the styling for really long headers is fine. I'm not sure how hard it would be to take a snapshot of both a heading and something below it, though.
frontend/src/components/shared/StreamlitMarkdown/StreamlitMarkdown.tsx
Outdated
Show resolved
Hide resolved
Author
|
@vdonato Ok, I added an e2e test to st_markdown which displays a long header and table in a block, then snapshots it. Also replied to your individual comments. |
vdonato
approved these changes
Apr 15, 2021
tconkling
added a commit
that referenced
this pull request
Apr 19, 2021
* develop: Fix Markdown Anchors bugs (#3127) Unset fail_on_warning (#3134) Remove fail on warning Merge pull request #3126 from randyzwitch/docs_test Add s4a message to close active modals (#2893) Add fail_on_warning to build options Docutils 0.16 Put back Sphinx to 3.0.3 Modify docs for grammatical error Update Changelog to latest updates Up version to 0.80.0 Update change log Revert "Merge pull request #3029 from streamlit/fix-1117" Merge anchor headers feature branch into develop (#2983)
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3115
Closes #3104
<h1>,<h2>, etc. toCustomHeader"unknown-anchor"in worst case)