Pin docutils to 0.16 #3126
Merged
Pin docutils to 0.16 #3126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdonato
approved these changes
Apr 13, 2021
mesmith027
approved these changes
Apr 13, 2021
Contributor
mesmith027
left a comment
mesmith027
left a comment
There was a problem hiding this comment.
Giving the rubber stamp to fix the Docs API issues we had from the other day
tconkling
added a commit
that referenced
this pull request
Apr 19, 2021
* develop: Fix Markdown Anchors bugs (#3127) Unset fail_on_warning (#3134) Remove fail on warning Merge pull request #3126 from randyzwitch/docs_test Add s4a message to close active modals (#2893) Add fail_on_warning to build options Docutils 0.16 Put back Sphinx to 3.0.3 Modify docs for grammatical error Update Changelog to latest updates Up version to 0.80.0 Update change log Revert "Merge pull request #3029 from streamlit/fix-1117" Merge anchor headers feature branch into develop (#2983)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
AttributeError: 'Values' object has no attribute 'tab_widtherror, reported internally and incorrectly fixed by #3076. docutils released a new version (0.17), which we were not pinning due to it being so infrequently being updated.sphinx-doc/sphinx#9049 (comment)
Visual inspection of the Streamlit API page shows that the docstrings and inline Streamlit apps are now deployed. While it appears that the Sphinx version itself may not be the cause of the error, leaving for future PR to address updating dependencies wholesale.
Edit: additionally sets
fail_on_warning: trueto try and fail faster when warnings are being thrown.