Fix: Add urllib import to streamlit hello #3106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmcgrady
approved these changes
Apr 13, 2021
Collaborator
kmcgrady
left a comment
kmcgrady
left a comment
There was a problem hiding this comment.
This is awesome! Thanks for the help!
tconkling
added a commit
that referenced
this pull request
Apr 13, 2021
* develop: (165 commits) Add s4a message to close active modals (#2893) Add fail_on_warning to build options Docutils 0.16 Put back Sphinx to 3.0.3 Add import urllib to streamlit hello (#2969) (#3106) Update Num_Input to correct for Type Errors (#3074) Upgrade bokehjs to 2.2.2, and run `npx browserslist@latest --update-db` (#3090) remove extra star in docs (#3086) Remove flake8 linting tool (#3085) Makefile cleanup (#3083) Merge anchor headers feature branch into develop (#2983) Fix image galleries (#3044) Is this a red herring also? See if pylint was red herring Update sphinx Specify pylint version Fix pylint errors Added "allow-downloads" to the sandbox attributes (#3053) Small fix for `make pylint` command (#3062) Set genericColors properly and make theme defs more consistent (#3051) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Resolves #2969
Description: As discussed in #2969, the mapping and dataframe demo from
streamlit helloare missing the URLError import in the code of example showed when the "show code" is checked. This commit addsfrom urllib.error import URLErrorto both examples.Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.