-
Notifications
You must be signed in to change notification settings - Fork 4k
Small fix for make pylint command
#3062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
vdonato
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @SimonBiggs!
We generally get two reviewers for community contributions (doing so for a PR of this size/scope is, of course, just a formality, but I'll just stick to the regular procedure here for consistency), so this should be merge-able once a second person is able to take a glance a this.
kantuni
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SimonBiggs, thank you!
* develop: Added "allow-downloads" to the sandbox attributes (#3053) Small fix for `make pylint` command (#3062) Set genericColors properly and make theme defs more consistent (#3051) Downgrade st.warning in local_sources_watcher to a log (#3050) Extend docstring of st.image (#3055) Move docs.streamlit.io to Segment (#3005) Fix bokeh example in docs (`legend` arg) (#2907) Remove incorrect markdown table styling (#3038) document getattr Show the beta_warning only a single time per object object_beta_warning: handle every __ magic method object_beta_warning: handle the subscript operator beta_util_test Move secrets out of beta [Security] Upgrade y18n to 4.0.1 or later (#3041) Fix gap not working on Safari (#3042) formatting call _repr_html_ when available
* st_form: Added "allow-downloads" to the sandbox attributes (streamlit#3053) Small fix for `make pylint` command (streamlit#3062) Set genericColors properly and make theme defs more consistent (streamlit#3051) Downgrade st.warning in local_sources_watcher to a log (streamlit#3050) Extend docstring of st.image (streamlit#3055) Move docs.streamlit.io to Segment (streamlit#3005) Fix bokeh example in docs (`legend` arg) (streamlit#2907) Remove incorrect markdown table styling (streamlit#3038) document getattr Show the beta_warning only a single time per object object_beta_warning: handle every __ magic method object_beta_warning: handle the subscript operator beta_util_test Move secrets out of beta [Security] Upgrade y18n to 4.0.1 or later (streamlit#3041) Fix gap not working on Safari (streamlit#3042) formatting call _repr_html_ when available
# By Tim Conkling (7) and others # Via GitHub (3) and Tim Conkling (1) * st_form: FormsManager (streamlit#3046) Added "allow-downloads" to the sandbox attributes (streamlit#3053) Small fix for `make pylint` command (streamlit#3062) Set genericColors properly and make theme defs more consistent (streamlit#3051) Downgrade st.warning in local_sources_watcher to a log (streamlit#3050) Extend docstring of st.image (streamlit#3055) Move docs.streamlit.io to Segment (streamlit#3005) Fix bokeh example in docs (`legend` arg) (streamlit#2907) Remove incorrect markdown table styling (streamlit#3038) document getattr Show the beta_warning only a single time per object object_beta_warning: handle every __ magic method object_beta_warning: handle the subscript operator beta_util_test Move secrets out of beta [Security] Upgrade y18n to 4.0.1 or later (streamlit#3041) Fix gap not working on Safari (streamlit#3042) formatting call _repr_html_ when available # Conflicts: # frontend/src/components/core/Block/Block.tsx # frontend/src/components/widgets/Form/Form.tsx # frontend/src/components/widgets/Form/FormSubmitButton.tsx # frontend/src/components/widgets/Form/FormsData.test.ts # frontend/src/components/widgets/Form/FormsManager.ts
* call _repr_html_ when available * formatting * Changes on the Git Deploy Button Frontend * Update Cypress screenshot * Small fix for `make pylint` command (#3062) * make 'pylint' actually raise a non-zero exit * run black so that 'make pylint' passes once more * Added "allow-downloads" to the sandbox attributes (#3053) * Added "allow-downloads" to the sandbox attributes This enables components to provide a download button for example for data or images. * Removed spaces * Fixed Typo * Trigger Build * Fix pylint errors * Specify pylint version * Update sphinx * See if pylint was red herring * Is this a red herring also? * Addressed PR comments * Update snapshots * Used separate variable * Update snapshot Co-authored-by: Jon Roes <[email protected]> Co-authored-by: Jon Roes <[email protected]> Co-authored-by: Emiliano Rosso <[email protected]> Co-authored-by: Simon Biggs <[email protected]> Co-authored-by: Finn <[email protected]> Co-authored-by: Randy Zwitch <[email protected]> Co-authored-by: Marisa Smith <[email protected]>
* develop: (165 commits) Add s4a message to close active modals (#2893) Add fail_on_warning to build options Docutils 0.16 Put back Sphinx to 3.0.3 Add import urllib to streamlit hello (#2969) (#3106) Update Num_Input to correct for Type Errors (#3074) Upgrade bokehjs to 2.2.2, and run `npx browserslist@latest --update-db` (#3090) remove extra star in docs (#3086) Remove flake8 linting tool (#3085) Makefile cleanup (#3083) Merge anchor headers feature branch into develop (#2983) Fix image galleries (#3044) Is this a red herring also? See if pylint was red herring Update sphinx Specify pylint version Fix pylint errors Added "allow-downloads" to the sandbox attributes (#3053) Small fix for `make pylint` command (#3062) Set genericColors properly and make theme defs more consistent (#3051) ...
Hi @kmcgrady,
This is a small drive-by fix for an issue where the
pylintcommand would previously fail internally but still give a 0 exit status, and therefore not raise an issue within the CI.