Fix image galleries #3044
Merged
Fix image galleries #3044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-requested a review
Author
|
Just kidding, this breaks on variable width columns. Need to think of new solution. May need to just use Update: Crisis averted, a tweak to |
ghost
closed this
ghost
reopened this
Collaborator
|
@bh-streamlit Created PR Preview...and I tried the example from the issue, and it's still pretty far off?
I would understand a pixel, but this seems really off. |
Author
|
Huh, yeah, that definitely looks like the old behavior. I will take a look tomorrow. |
Author
kmcgrady
approved these changes
Apr 2, 2021
Collaborator
kmcgrady
left a comment
kmcgrady
left a comment
There was a problem hiding this comment.
This responsive behavior is a bit weird, but it may be a part of the spec (essentially the column is now full width, so make it expand the width.
That being said. It works for me in Safari and Brave and small sizes.
tconkling
added a commit
that referenced
this pull request
Apr 6, 2021
* develop: Fix image galleries (#3044) Is this a red herring also? See if pylint was red herring Update sphinx Specify pylint version Fix pylint errors
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Apr 6, 2021
* st_form: Fix image galleries (streamlit#3044) Is this a red herring also? See if pylint was red herring Update sphinx Specify pylint version Fix pylint errors
tconkling
added a commit
that referenced
this pull request
Apr 13, 2021
* develop: (165 commits) Add s4a message to close active modals (#2893) Add fail_on_warning to build options Docutils 0.16 Put back Sphinx to 3.0.3 Add import urllib to streamlit hello (#2969) (#3106) Update Num_Input to correct for Type Errors (#3074) Upgrade bokehjs to 2.2.2, and run `npx browserslist@latest --update-db` (#3090) remove extra star in docs (#3086) Remove flake8 linting tool (#3085) Makefile cleanup (#3083) Merge anchor headers feature branch into develop (#2983) Fix image galleries (#3044) Is this a red herring also? See if pylint was red herring Update sphinx Specify pylint version Fix pylint errors Added "allow-downloads" to the sandbox attributes (#3053) Small fix for `make pylint` command (#3062) Set genericColors properly and make theme defs more consistent (#3051) ...
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3013, essentially by using our
gappolyfill everywhere, not just at small resolutions. Our polyfill requires we set the width/flex-basis of columns tocalc(${width} - ${gap})instead of just${width}, so did that too.I've tested and the logic appears to work. The layout is what we want it to be, and works when you resize the viewport. Here's the code I'm testing with:
Unfortunately, there is one tiny problem. In the image gallery, one of the images is one infuriating pixel smaller than the others. This is happening because of the sizes being given to us by
AutoSizer. Apparently this is a known issue.I am going to suggest we merge this PR for now, since it fixes a whole class of sizing issues, and figure out this one off pixel problem at a later time.