Remove incorrect markdown table styling #3038
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdonato
force-pushed
the
theming-markdown-tables
branch
from
fe3d84a to
53c00a5
Compare
We ended up letting a markdown table styling bug slip through where tables are always displayed with a white background color due to an override that I guess was left over from the pre-theming days. Closes streamlit#3020
vdonato
force-pushed
the
theming-markdown-tables
branch
from
53c00a5 to
3480549
Compare
tconkling
added a commit
that referenced
this pull request
Apr 5, 2021
* develop: Added "allow-downloads" to the sandbox attributes (#3053) Small fix for `make pylint` command (#3062) Set genericColors properly and make theme defs more consistent (#3051) Downgrade st.warning in local_sources_watcher to a log (#3050) Extend docstring of st.image (#3055) Move docs.streamlit.io to Segment (#3005) Fix bokeh example in docs (`legend` arg) (#2907) Remove incorrect markdown table styling (#3038) document getattr Show the beta_warning only a single time per object object_beta_warning: handle every __ magic method object_beta_warning: handle the subscript operator beta_util_test Move secrets out of beta [Security] Upgrade y18n to 4.0.1 or later (#3041) Fix gap not working on Safari (#3042) formatting call _repr_html_ when available
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Apr 5, 2021
* st_form: Added "allow-downloads" to the sandbox attributes (streamlit#3053) Small fix for `make pylint` command (streamlit#3062) Set genericColors properly and make theme defs more consistent (streamlit#3051) Downgrade st.warning in local_sources_watcher to a log (streamlit#3050) Extend docstring of st.image (streamlit#3055) Move docs.streamlit.io to Segment (streamlit#3005) Fix bokeh example in docs (`legend` arg) (streamlit#2907) Remove incorrect markdown table styling (streamlit#3038) document getattr Show the beta_warning only a single time per object object_beta_warning: handle every __ magic method object_beta_warning: handle the subscript operator beta_util_test Move secrets out of beta [Security] Upgrade y18n to 4.0.1 or later (streamlit#3041) Fix gap not working on Safari (streamlit#3042) formatting call _repr_html_ when available
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Apr 5, 2021
# By Tim Conkling (7) and others # Via GitHub (3) and Tim Conkling (1) * st_form: FormsManager (streamlit#3046) Added "allow-downloads" to the sandbox attributes (streamlit#3053) Small fix for `make pylint` command (streamlit#3062) Set genericColors properly and make theme defs more consistent (streamlit#3051) Downgrade st.warning in local_sources_watcher to a log (streamlit#3050) Extend docstring of st.image (streamlit#3055) Move docs.streamlit.io to Segment (streamlit#3005) Fix bokeh example in docs (`legend` arg) (streamlit#2907) Remove incorrect markdown table styling (streamlit#3038) document getattr Show the beta_warning only a single time per object object_beta_warning: handle every __ magic method object_beta_warning: handle the subscript operator beta_util_test Move secrets out of beta [Security] Upgrade y18n to 4.0.1 or later (streamlit#3041) Fix gap not working on Safari (streamlit#3042) formatting call _repr_html_ when available # Conflicts: # frontend/src/components/core/Block/Block.tsx # frontend/src/components/widgets/Form/Form.tsx # frontend/src/components/widgets/Form/FormSubmitButton.tsx # frontend/src/components/widgets/Form/FormsData.test.ts # frontend/src/components/widgets/Form/FormsManager.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ended up letting a markdown table styling bug slip through where tables are
always displayed with a white background color due to an override that I
guess was left over from the pre-theming days.
Closes #3020