ComponentInstance: handle iframe changes #3015
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmcgrady
approved these changes
Mar 28, 2021
Collaborator
kmcgrady
left a comment
kmcgrady
left a comment
There was a problem hiding this comment.
This looks fantastic. Thanks for helping this out!
tconkling
added a commit
that referenced
this pull request
Mar 30, 2021
* develop: Set baseUrl to . Speed up CircleCI more (#3025) Add events to keep track of theme changes and other theme stats (#3012) Have MetricsManager enqueue events when disconnected (#3011) Fix for query param issue with base url (#2894) Add fuzzy search to selectbox (#2933) Informative repr methods for our python classes (#3027) ComponentInstance: handle iframe changes (#3015)
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Mar 30, 2021
* st_form: Set baseUrl to . Speed up CircleCI more (streamlit#3025) Add events to keep track of theme changes and other theme stats (streamlit#3012) Have MetricsManager enqueue events when disconnected (streamlit#3011) Fix for query param issue with base url (streamlit#2894) Add fuzzy search to selectbox (streamlit#2933) Informative repr methods for our python classes (streamlit#3027) ComponentInstance: handle iframe changes (streamlit#3015)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a ComponentInstance is reordered in the DOM - which can happen as the result of a script re-run - its iframe will be re-mounted, and get a new
contentWindow. A Component sends messages to Streamlit via itscontentWindow-- and since we currently don't detect a change tocontentWindow, a remounted Component iframe will send messages that just get dropped on the floor byComponentRegistry.This PR detects
contentWindowchanges during component update and re-registers the component's message listener.(Most of the hard work of discovery, making a repro-able test case, and finding the solution is thanks to @erumoico: https://github.com/erumoico/streamlit-issue_2720)
Fixes #2720