Have MetricsManager enqueue events when disconnected #3011
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, MetricsManager only enqueues events when we attempt to send them before it has been initialized, so trying to send an event when MetricsManager was initialized but the app is disconnected from the server results in an error being thrown. This generally doesn't happen very much in practice (you see it from time to time when developing streamlit itself when the react dev server reloads files, but I'm not aware of any other instances where we run into this). Some of the theme metrics that I want to add, however, will run into this when trying to record that a user changed their app's theme while the app is disconnected, so this needs to be fixed before those metrics can be added. Closes streamlit#2958
vdonato
force-pushed
the
metrics-manager-disconnect-handling
branch
from
f2807ab to
bffad1f
Compare
ghost
approved these changes
Mar 29, 2021
vdonato
added a commit
to vdonato/streamlit
that referenced
this pull request
Mar 29, 2021
Note: This builds off streamlit#3011, so that PR should be reviewed first. With a few small issues with MetricsManager cleaned up, we can now collect all the theme-related data points we wanted to.
vdonato
added a commit
that referenced
this pull request
Mar 29, 2021
Note: This builds off #3011, so that PR should be reviewed first. With a few small issues with MetricsManager cleaned up, we can now collect all the theme-related data points we wanted to.
tconkling
added a commit
that referenced
this pull request
Mar 30, 2021
* develop: Set baseUrl to . Speed up CircleCI more (#3025) Add events to keep track of theme changes and other theme stats (#3012) Have MetricsManager enqueue events when disconnected (#3011) Fix for query param issue with base url (#2894) Add fuzzy search to selectbox (#2933) Informative repr methods for our python classes (#3027) ComponentInstance: handle iframe changes (#3015)
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Mar 30, 2021
* st_form: Set baseUrl to . Speed up CircleCI more (streamlit#3025) Add events to keep track of theme changes and other theme stats (streamlit#3012) Have MetricsManager enqueue events when disconnected (streamlit#3011) Fix for query param issue with base url (streamlit#2894) Add fuzzy search to selectbox (streamlit#2933) Informative repr methods for our python classes (streamlit#3027) ComponentInstance: handle iframe changes (streamlit#3015)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, MetricsManager only enqueues events when we attempt to send
them before it has been initialized, so trying to send an event when
MetricsManager was initialized but the app is disconnected from the
server results in an error being thrown.
This generally doesn't happen very much in practice (you see it from
time to time when developing streamlit itself when the react dev server
reloads files, but I'm not aware of any other instances where we run into
this).
Some of the theme metrics that I want to add, however, will run into
this when trying to record that a user changed their app's theme while
the app is disconnected, so this needs to be fixed before those metrics
can be added.
Closes #2958