Stop warn logs from being spammed in dev mode due to override names #2994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed a bunch of warn logs in my browser console every time a tooltip is rendered, and it turns out the reason for this was essentially the same reason from when this appeared last / was solved by streamlit#2938. This doesn't affect non-dev setups, so I'm not sure how big of a deal this actually is and whether we should make it a convention to always use the long names in BaseWeb overrides.
AnOctopus
approved these changes
Mar 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a bunch of warn logs in my browser console every time a tooltip is
rendered, and it turns out the reason for this was essentially the same
reason from when this appeared last / was solved by #2938.
This doesn't affect non-dev setups, so I'm not sure how big of a deal this
actually is and whether we should make it a convention to always use the
long names in BaseWeb overrides.