Add tests to improve coverage around config options set via flag #2991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@kantuni pointed out in a previous PR that our test coverage around config options set via CLI flag was lacking, and now that 0.79/theming has landed I had a bit of time to improve this.
tconkling
added a commit
that referenced
this pull request
Mar 24, 2021
# By Vincent Donato (3) and Nikitas Rontsis (1) # Via GitHub * develop: Have theme hashes differentiate between being unset and the hash for null (#2993) Improve module reloading (#3001) Add tests to improve coverage around config options set via flag (#2991) Add snippets about CSS vars and minimum streamlit-component-lib versions (#3008) # Conflicts: # frontend/src/App.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kantuni pointed out in a previous PR that our test coverage around config
options set via CLI flag was lacking, and now that 0.79/theming has
landed I had a bit of time to improve this.