Merge anchor headers feature branch into develop #2983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* save progress * save work * remove junk code * fix lint errors * clean up code a bit * fix incorrect type * remove debug code * fix heading numbers * make requested changes and clean up HeadingWithAnchor * only scroll once * fix issues * fix jslint * clean things up * handle edge case * missing a void * fix failing test * add e2e tests * add e2e tests * clean up code by using _.once() * fix lint * fix dynamic scrolling * fix typo * make requested changes * run formatting and remove unused import * remove another unused import * make requested changes * add nice link icon to left of headers
…amlit into feat/anchor-headers
ghost
self-requested a review
* fix anchor styling * Revert "fix anchor styling" This reverts commit cb5d7fd. * fix failing cypress tests
* add communication with s4a * fix bug * save work * save work * remove console * add tests * remove useless import * fix failing tests
ghost
added
the
…amlit into feat/anchor-headers
* remove markdown anchors from sidebar * fix test * add tests
|
LGTM pending verification of Anchor Tags removal in sidebar 👍 |
…amlit into feat/anchor-headers
* see if this fixes things * fix things * fix * fix scrolling * add spacer * save work * remove unneeded changes
kmcgrady
approved these changes
Apr 6, 2021
kmcgrady
pushed a commit
that referenced
this pull request
Apr 8, 2021
* Add anchors to Markdown headers (#2513) * save progress * save work * remove junk code * fix lint errors * clean up code a bit * fix incorrect type * remove debug code * fix heading numbers * make requested changes and clean up HeadingWithAnchor * only scroll once * fix issues * fix jslint * clean things up * handle edge case * missing a void * fix failing test * add e2e tests * add e2e tests * clean up code by using _.once() * fix lint * fix dynamic scrolling * fix typo * make requested changes * run formatting and remove unused import * remove another unused import * make requested changes * add nice link icon to left of headers * make requested design changes (#2726) * Fix anchor styling to work with dark mode (#3035) * fix anchor styling * Revert "fix anchor styling" This reverts commit cb5d7fd. * fix failing cypress tests * fix styling * Add S4A communication for anchor headers (#2982) * add communication with s4a * fix bug * save work * save work * remove console * add tests * remove useless import * fix failing tests * Remove Markdown anchors from sidebar (#3059) * remove markdown anchors from sidebar * fix test * add tests * Fix failing Cypress test for Markdown Anchors (#3077) * see if this fixes things * fix things * fix * fix scrolling * add spacer * save work * remove unneeded changes
tconkling
added a commit
that referenced
this pull request
Apr 13, 2021
* develop: (165 commits) Add s4a message to close active modals (#2893) Add fail_on_warning to build options Docutils 0.16 Put back Sphinx to 3.0.3 Add import urllib to streamlit hello (#2969) (#3106) Update Num_Input to correct for Type Errors (#3074) Upgrade bokehjs to 2.2.2, and run `npx browserslist@latest --update-db` (#3090) remove extra star in docs (#3086) Remove flake8 linting tool (#3085) Makefile cleanup (#3083) Merge anchor headers feature branch into develop (#2983) Fix image galleries (#3044) Is this a red herring also? See if pylint was red herring Update sphinx Specify pylint version Fix pylint errors Added "allow-downloads" to the sandbox attributes (#3053) Small fix for `make pylint` command (#3062) Set genericColors properly and make theme defs more consistent (#3051) ...
tconkling
added a commit
that referenced
this pull request
Apr 19, 2021
* develop: Fix Markdown Anchors bugs (#3127) Unset fail_on_warning (#3134) Remove fail on warning Merge pull request #3126 from randyzwitch/docs_test Add s4a message to close active modals (#2893) Add fail_on_warning to build options Docutils 0.16 Put back Sphinx to 3.0.3 Modify docs for grammatical error Update Changelog to latest updates Up version to 0.80.0 Update change log Revert "Merge pull request #3029 from streamlit/fix-1117" Merge anchor headers feature branch into develop (#2983)
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was previously merged, but had to revert because of a bug integrating with S4A. New additions are after c69b291.
Just needs product review at this point. All code has been reviewed, ready for the final +1 formality to be merged in.