Refactor CodeBlock.tsx #2814
Merged
Refactor CodeBlock.tsx #2814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-requested a review
ghost
mentioned this pull request
vdonato
reviewed
Feb 18, 2021
Collaborator
vdonato
left a comment
vdonato
left a comment
There was a problem hiding this comment.
LGTM, but I'll wait on the other change to go in before +1-ing to prevent merges accidentally going in out of order.
I think this also technically will require @asaini to look at it since it's a behavioral change (I'm guessing both PRs can be reviewed at once), but I agree that the new behavior is more correct than defaulting to python if the requested language isn't supported.
vdonato
approved these changes
Feb 24, 2021
Collaborator
vdonato
left a comment
vdonato
left a comment
There was a problem hiding this comment.
Going to +1 before the prereq PR is merged since this + the prereq change are both waiting on the same product review and I'm sure accidentally hitting submit on this one first isn't a real concern
|
LGTM👍 The change described in this PR makes sense. Feels right to not show incorrect highlighting if a language is not supported. |
Author
|
Awesome, just pending approval of #2808 then. |
tconkling
added a commit
that referenced
this pull request
Mar 1, 2021
* develop: (29 commits) Update bug_report.md Refactor CodeBlock.tsx (#2814) Remove copy button for empty codeblocks (#2808) Add image format deprecation config with expiration (#2865) Remove unneeded "use_column_width=True" from our doc examples (#2692) Extend our st.cache MagicMock handling logic to Mock (#2846) save work (#2862) Remove .stale-element class (#2848) Release 0.77 (#2849) Fix watchdog import failure (#2856) 🔥 Fully remove `format` param from st.image (#2637) Don't memoize config._server_headless (#2858) hide empty columns on mobile (#2756) st.beta_secrets (#2757) `watch_file` utility function (#2851) Align st.beta_columns (#2811) Update "showErrorDetails" config description and docs (#2841) Pause Dependabot updates for non-security-related issues (#2840) client.showTracebacks -> showErrorDetails (per product) (#2837) Color picker - show value (#2817) ...
This was referenced Apr 16, 2021
vdonato
added a commit
to vdonato/streamlit
that referenced
this pull request
Apr 26, 2021
We changed the behavior of auto-syntax highlighting in code blocks in streamlit#2814 to *not* attempt to highlight code as if it were python if the language specified isn't a supported one, which had the side effect of removing syntax highlighting from toml code blocks (toml was being highlighted as if it were python). This change adds toml highlighting back using prismjs' native support. We also re-order and re-group the imports in the file.
vdonato
added a commit
that referenced
this pull request
May 13, 2021
We changed the behavior of auto-syntax highlighting in code blocks in #2814 to *not* attempt to highlight code as if it were python if the language specified isn't a supported one, which had the side effect of removing syntax highlighting from toml code blocks (toml was being highlighted as if it were python). This change adds toml highlighting back using prismjs' native support. We also re-order and re-group the imports in the file.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors CodeBlock per suggestion here. I also changed some of the logic around handling different values of
language. Our old logic was:languagein table of supported languagesThis is slightly incorrect; it should only default to Python if no language is requested. If a language is requested but not supported, we should just not highlight — if the user requests Brainfuck and we default to Python, we'll just produce incorrect highlighting.
(Forked this branch off #2808, the diff will shrink once that's merged.)