Minor improvements to local E2E testing #2807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 17, 2021 12:09
ghost
self-requested a review
karriebear
approved these changes
Feb 17, 2021
| // enable printing to terminal | ||
| on("task", { | ||
| log(message) { | ||
| console.log(message) |
Contributor
There was a problem hiding this comment.
Don't have anything against this but doesn't console.log already work? The annoying part is it prints into the browser console of the test run but wouldn't this do the same?
Author
There was a problem hiding this comment.
Based on my understanding, which is based on the internet, which is never wrong, I believe Cypress tasks let you register bits of JS code that run in the Node instance, i.e. the terminal, when cy.task is called.
Whatever's actually happening under the hood, all I'm aware of is that cy.task("log", "whatever") makes whatever show up in my terminal 😛
Contributor
There was a problem hiding this comment.
Ahh I clearly missed the comment. Thought this was for logging into the browser, not terminal
schaumb
pushed a commit
to FloWide/streamlit
that referenced
this pull request
Feb 22, 2021
* improve local testing experience * save
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Feb 22, 2021
* develop: Color picker - show value (streamlit#2817) Minor improvements to local E2E testing (streamlit#2807) Fix datetime timezone handling in data frames (streamlit#2784) Remove nonexistent elements from widget state (streamlit#2760) Shared selectbox (streamlit#2795)
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Feb 24, 2021
* develop: Update "showErrorDetails" config description and docs (streamlit#2841) Pause Dependabot updates for non-security-related issues (streamlit#2840) client.showTracebacks -> showErrorDetails (per product) (streamlit#2837) Color picker - show value (streamlit#2817) Minor improvements to local E2E testing (streamlit#2807) Fix datetime timezone handling in data frames (streamlit#2784) Remove nonexistent elements from widget state (streamlit#2760) Shared selectbox (streamlit#2795)
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cy.task("log", "whatever")