Skip to content

Conversation

@SimonBiggs
Copy link
Contributor

Docstring adjustment

@SimonBiggs SimonBiggs requested a review from a team February 9, 2021 02:29
@karriebear
Copy link
Contributor

Total fail, thanks for catching and fixing this!

@karriebear karriebear merged commit b4a9f3e into streamlit:develop Feb 9, 2021
@SimonBiggs
Copy link
Contributor Author

SimonBiggs commented Feb 9, 2021

thanks for catching and fixing this!

My pleasure 🙂

@SimonBiggs SimonBiggs deleted the patch-2 branch February 9, 2021 03:47
tconkling added a commit to tconkling/streamlit that referenced this pull request Feb 11, 2021
* develop:
  Slider thumb values are always visible (streamlit#2724)
  Update component-template submodule to latest (streamlit#2767)
  `allow_multiple_files` -> `accept_multiple_files` (streamlit#2761)
  Autofocus "clear cache" button (streamlit#2739)
  Fix checkbox spacing (streamlit#2738)
  Fix progress bar alignment (streamlit#2734)
  Fix select menu not autoselecting first item (streamlit#2732)
  Show user command line in disconnect dialog (streamlit#2735)
  Up version to 0.76.0
  Update change log
  Improve usage warning wording and formatting
  Finally remove beta versions of set_page_config and color_picker (streamlit#2711)
  Finally remove beta versions of set_page_config and color_picker (streamlit#2711)
  Clean up file update calls (streamlit#2597)
tconkling added a commit to tconkling/streamlit that referenced this pull request Feb 16, 2021
* develop:
  config: client.showTracebacks (streamlit#2770)
  Create base color picker for use with API and internally (streamlit#2778)
  Slider thumb values are always visible (streamlit#2724)
  Update component-template submodule to latest (streamlit#2767)
  `allow_multiple_files` -> `accept_multiple_files` (streamlit#2761)
CFrez pushed a commit to CFrez/streamlit that referenced this pull request Feb 18, 2021
schaumb pushed a commit to FloWide/streamlit that referenced this pull request Feb 22, 2021
kmcgrady pushed a commit that referenced this pull request Feb 24, 2021
* created conditional rendering of controls & tests

* reorganized and added tests

* removed accidently added unneeded import

* alter flex, padding and gap to align columns

* adjusted spacing since not duplicated

* alter flex, padding and gap to align columns

* adjusted spacing since not duplicated

* Fix checkbox spacing (#2738)

* remove extra padding

* remove snapshot completely

* add snapshot back in

* remove snapshots

* remove rest of snapshots

* add snapshots back in

* Autofocus "clear cache" button (#2739)

* autofocus clear cache button

* add test

* update test

* fix lint

* `allow_multiple_files` -> `accept_multiple_files` (#2761)

* Update component-template submodule to latest (#2767)

Point our `component-template` submodule to the latest commit in that repo.

(Among other things, this will de-dupe a bunch of the `component-lib` code that used to live in `component-template` before being pulled into its own npm package.)

* Slider thumb values are always visible (#2724)

* Close #2699

* Override Thumb subcomponent completely

* Fixed linting errors

Co-authored-by: Ken McGrady <[email protected]>

* Create base color picker for use with API and internally (#2778)

* Copy to shared and cleanup

* Cleanup

* remove comment

* config: client.showTracebacks (#2770)

Adds a new config option, `"client.showTracebacks"`. By default, it's `True`.

If the option is set to `False`, then uncaught exceptions in a Streamlit app will result in a generic "Something went wrong!" warning in the browser, rather than the exception and its traceback

This logic happens in the `error_util.handle_uncaught_app_exception` function, rather than directly within ScriptRunner.

`scriptrunner_test`, `caching_test`, and `streamlit_test` have new tests that verify the right thing happens when exceptions are thrown in different circumstances with this config option turned on and off.

Closes #1032

* Shared selectbox (#2795)

* Remove nonexistent elements from widget state (#2760)

* remove nonexistent elements from widget states

* fix typo

* add test

* Fix datetime timezone handling in data frames (#2784)

* save changes

* remove redundant change

* fix tests

* fix quotes

* add tests and other fixes

* fix lint

* update protobufs and tests

* add e2e test

* fix quotes

* update test

* Revert "removed accidently added unneeded import"

This reverts commit f886adc.

* Revert "reorganized and added tests"

This reverts commit d3632d9.

* Revert "created conditional rendering of controls & tests"

This reverts commit 7c4400e.

* updated tests

* fixed lint

* correct percentages in spec for test

* update st_image column image

* added comment to HoizontalBlock

* added Issue/PR to comment

Co-authored-by: bh-streamlit <[email protected]>
Co-authored-by: Simon Biggs <[email protected]>
Co-authored-by: Tim Conkling <[email protected]>
Co-authored-by: Henrikh Kantuni <[email protected]>
Co-authored-by: Ken McGrady <[email protected]>
Co-authored-by: karrie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants