Show user command line in disconnect dialog #2735
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-requested a review
kmcgrady
approved these changes
Feb 5, 2021
Collaborator
|
Looks good. There's some cypress issues, but hopefully this is easy. |
added 3 commits
February 5, 2021 13:13
tconkling
added a commit
that referenced
this pull request
Feb 8, 2021
* develop: Autofocus "clear cache" button (#2739) Fix checkbox spacing (#2738) Fix progress bar alignment (#2734) Fix select menu not autoselecting first item (#2732) Show user command line in disconnect dialog (#2735) Up version to 0.76.0 Update change log Improve usage warning wording and formatting Finally remove beta versions of set_page_config and color_picker (#2711) Finally remove beta versions of set_page_config and color_picker (#2711) Clean up file update calls (#2597)
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Feb 11, 2021
* develop: Slider thumb values are always visible (streamlit#2724) Update component-template submodule to latest (streamlit#2767) `allow_multiple_files` -> `accept_multiple_files` (streamlit#2761) Autofocus "clear cache" button (streamlit#2739) Fix checkbox spacing (streamlit#2738) Fix progress bar alignment (streamlit#2734) Fix select menu not autoselecting first item (streamlit#2732) Show user command line in disconnect dialog (streamlit#2735) Up version to 0.76.0 Update change log Improve usage warning wording and formatting Finally remove beta versions of set_page_config and color_picker (streamlit#2711) Finally remove beta versions of set_page_config and color_picker (streamlit#2711) Clean up file update calls (streamlit#2597)
schaumb
pushed a commit
to FloWide/streamlit
that referenced
this pull request
Feb 22, 2021
* show user command line on disconnect * force ci rerun * force ci rerun * fix xsrf issue
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2667.
The issue was that our disconnect dialog grabs the user command from SessionInfo.current.commandLine, which is tragicomically unavailable because we have just disconnected. So this PR basically does two things: