Add design changes to anchor headers #2726
Merged
+36
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-requested a review
ghost
pushed a commit
that referenced
this pull request
Apr 6, 2021
* Add anchors to Markdown headers (#2513) * save progress * save work * remove junk code * fix lint errors * clean up code a bit * fix incorrect type * remove debug code * fix heading numbers * make requested changes and clean up HeadingWithAnchor * only scroll once * fix issues * fix jslint * clean things up * handle edge case * missing a void * fix failing test * add e2e tests * add e2e tests * clean up code by using _.once() * fix lint * fix dynamic scrolling * fix typo * make requested changes * run formatting and remove unused import * remove another unused import * make requested changes * add nice link icon to left of headers * make requested design changes (#2726) * Fix anchor styling to work with dark mode (#3035) * fix anchor styling * Revert "fix anchor styling" This reverts commit cb5d7fd. * fix failing cypress tests * fix styling * Add S4A communication for anchor headers (#2982) * add communication with s4a * fix bug * save work * save work * remove console * add tests * remove useless import * fix failing tests * Remove Markdown anchors from sidebar (#3059) * remove markdown anchors from sidebar * fix test * add tests * Fix failing Cypress test for Markdown Anchors (#3077) * see if this fixes things * fix things * fix * fix scrolling * add spacer * save work * remove unneeded changes
kmcgrady
pushed a commit
that referenced
this pull request
Apr 8, 2021
* Add anchors to Markdown headers (#2513) * save progress * save work * remove junk code * fix lint errors * clean up code a bit * fix incorrect type * remove debug code * fix heading numbers * make requested changes and clean up HeadingWithAnchor * only scroll once * fix issues * fix jslint * clean things up * handle edge case * missing a void * fix failing test * add e2e tests * add e2e tests * clean up code by using _.once() * fix lint * fix dynamic scrolling * fix typo * make requested changes * run formatting and remove unused import * remove another unused import * make requested changes * add nice link icon to left of headers * make requested design changes (#2726) * Fix anchor styling to work with dark mode (#3035) * fix anchor styling * Revert "fix anchor styling" This reverts commit cb5d7fd. * fix failing cypress tests * fix styling * Add S4A communication for anchor headers (#2982) * add communication with s4a * fix bug * save work * save work * remove console * add tests * remove useless import * fix failing tests * Remove Markdown anchors from sidebar (#3059) * remove markdown anchors from sidebar * fix test * add tests * Fix failing Cypress test for Markdown Anchors (#3077) * see if this fixes things * fix things * fix * fix scrolling * add spacer * save work * remove unneeded changes
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR preview. Script is the default script. I positioned images and headers so you can compare the behavior of the fullscreen button + the link icon.