Revert "🔧 "Run on save" now defaults to true" #2694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a63ab82.
akrolsmir
approved these changes
Feb 2, 2021
Contributor
akrolsmir
left a comment
akrolsmir
left a comment
There was a problem hiding this comment.
The revert LGTM. Not really sure what's going on with that smoke test though...
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Feb 2, 2021
* develop: Fix svg rendering in st.image() (streamlit#2666) Indicate widgets need to have labels (streamlit#2688) Clean up file update calls (streamlit#2597) Revert "🔧 "Run on save" now defaults to true (streamlit#2641)" (streamlit#2694)
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Feb 2, 2021
* develop: Fix svg rendering in st.image() (streamlit#2666) Indicate widgets need to have labels (streamlit#2688) Clean up file update calls (streamlit#2597) Revert "🔧 "Run on save" now defaults to true (streamlit#2641)" (streamlit#2694)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on review with product, revert for now and release once this change has been communicated out to our users and a pre-determined waiting time has passed.
This could potentially break users workflow, in particular if users hit an API with a limit without any caching. Frequent reruns could throttle their workflow.