ReportContext: simplify constructor #2669
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't change any behavior - ReportContext was only ever passed its own copy of this object.
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Jan 27, 2021
* develop: ReportContext constructs its own widget_ids_this_run (streamlit#2669) Add types to report_thread.py (streamlit#2665) Take scrollbars into account when computing Dataframe dimensions (streamlit#2622) Revert "Revert "Revert "Add anchors to Markdown headers (streamlit#2513)""" (streamlit#2664) ♻️ Remove "_proto" from "data_frame_proto.py" (streamlit#2640)
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Jan 27, 2021
* develop: ReportContext constructs its own widget_ids_this_run (streamlit#2669) Add types to report_thread.py (streamlit#2665)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReportContext now constructs its own
widget_ids_this_run. This doesn't change any behavior - ReportContext was only ever passed its own copy of this object. (ReportThreadis the only non-test code that constructs a ReportContext.)(This also cleans up a few instances where tests were incorrectly constructing ReportContexts with
nullvalues for non-nullable members.)