Extract a shared radio component for use within our UI #2657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karriebear
force-pushed
the
shared-radio
branch
from
6a94aa2 to
5a2c5ce
Compare
vdonato
approved these changes
Jan 25, 2021
Collaborator
vdonato
left a comment
vdonato
left a comment
There was a problem hiding this comment.
LGTM! I'm guessing this component previously didn't have unit tests?
Collaborator
There was a problem hiding this comment.
nit: 2020 -> 2021 / same thing in other new files
Contributor
Author
|
We had unit tests for the component that was st.radio but this is pulling out a new one and leaving the current one that maps to st.radio just an intermediary that translates between our proto/element with the radio button :) |
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Jan 25, 2021
* develop: Display a warning when not run via `streamlit run` (streamlit#2643) Extract a shared radio component for use within our UI (streamlit#2657) 🔧 "Run on save" now defaults to true (streamlit#2641) Bump year to 2021 in license headers (streamlit#2654) Switched react-katex package (streamlit#2619) Don't add license headers for files in node_modules and cypress folders (streamlit#2655)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a Radio that does not need to deal with widgetMgr or element. This is for us to use while sharing the same visuals as what st.radio outputs
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.