Skip to content

Conversation

@kantuni
Copy link
Collaborator

@kantuni kantuni commented Jan 25, 2021

Nothing fancy, just ran add_license_headers.py.

@kantuni kantuni requested a review from a team January 25, 2021 09:59
@@ -520,8 +520,10 @@ def require_widgets_deltas(

# If we get here, at least 1 runner hasn't yet completed before our
# timeout. Create an error string for debugging.
err_string = "require_widgets_deltas() timed out after {}s ({}/{} runners complete)".format(
timeout, num_complete, len(runners)
err_string = (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to prove I'm not just rubberstamping these things, here's the one place where Black formatted the code besides just changing the header 🤣

Copy link
Contributor

@randyzwitch randyzwitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, all 793 files

Copy link
Contributor

@tconkling tconkling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@akrolsmir
Copy link
Contributor

Opportunistically merging this while tests are passing and there are no conflicts, cuz this one touches a lot of files

@akrolsmir akrolsmir merged commit 49770d0 into develop Jan 25, 2021
tconkling added a commit to tconkling/streamlit that referenced this pull request Jan 25, 2021
* develop:
  Display a warning when not run via `streamlit run` (streamlit#2643)
  Extract a shared radio component for use within our UI (streamlit#2657)
  🔧 "Run on save" now defaults to true (streamlit#2641)
  Bump year to 2021 in license headers (streamlit#2654)
  Switched react-katex package (streamlit#2619)
  Don't add license headers for files in node_modules and cypress folders (streamlit#2655)
@kantuni kantuni deleted the update/headers branch January 28, 2021 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants