Display a warning when not run via streamlit run
#2643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This functionality used to exist, but stopped being called at some point. The check is executed in the DeltaGenerator, because that is one of the few things that will almost certainly be used by a user who is just importing the library.
karriebear
approved these changes
Jan 25, 2021
| """Allows us to create and absorb changes (aka Deltas) to elements.""" | ||
| from typing import Optional, Iterable, List | ||
|
|
||
| import streamlit as st |
Contributor
There was a problem hiding this comment.
Could we just import _maybe_print_use_warning instead of everything?
Contributor
Author
There was a problem hiding this comment.
We could, but this is how the style guide prefers
Contributor
There was a problem hiding this comment.
Hmm I want to say this would be a good exception for that but I'm not strongly tied to it
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Jan 25, 2021
* develop: Display a warning when not run via `streamlit run` (streamlit#2643) Extract a shared radio component for use within our UI (streamlit#2657) 🔧 "Run on save" now defaults to true (streamlit#2641) Bump year to 2021 in license headers (streamlit#2654) Switched react-katex package (streamlit#2619) Don't add license headers for files in node_modules and cypress folders (streamlit#2655)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This functionality used to exist, but stopped being called at some point.
The check is executed in the DeltaGenerator, because that is one of the few
things that will almost certainly be used by a user who is just importing the library.
Issue: #127