🔧 "Run on save" now defaults to true #2641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://www.notion.so/streamlit/Always-Rerun-should-be-the-default-09fcc67fa96940a9b9447c18b48003d7: ## Background Changing the source file of a Streamlit app brings this up:  - Always rerun seems like a better default; most users want this behavior - Some users do not want this behavior; we should allow them to - There is an existing config option "server.runOnSave" which defaults to False - server.runOnSave is true for S4A; this lets a git push to quickly update an S4A app. - There is a new config option "server.allowRunOnSave" which was hacked in for the S4A launch, preventing users from turning off this behavior. ## Proposal DECISION: Change the default on the existing "server.runOnSave" to True. Users can opt out by setting it to False.
|
LGTM 👍 |
kantuni
approved these changes
Jan 25, 2021
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Jan 25, 2021
](https://s3-us-west-2.amazonaws.com/secure.notion-static.com/81400e8d-f287-4533-828d-9b187e722973/Screen_Shot_2020-10-22_at_12.13.17_PM.png](https://s3-us-west-2.amazonaws.com/secure.notion-static.com/81400e8d-f287-4533-828d-9b187e722973/Screen_Shot_2020-10-22_at_12.13.17_PM.png)){kind=link}
* develop: Display a warning when not run via `streamlit run` (streamlit#2643) Extract a shared radio component for use within our UI (streamlit#2657) 🔧 "Run on save" now defaults to true (streamlit#2641) Bump year to 2021 in license headers (streamlit#2654) Switched react-katex package (streamlit#2619) Don't add license headers for files in node_modules and cypress folders (streamlit#2655)
karriebear
added a commit
that referenced
this pull request
Feb 2, 2021
This reverts commit a63ab82.
karriebear
added a commit
that referenced
this pull request
Feb 2, 2021
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Feb 2, 2021
* develop: Fix svg rendering in st.image() (streamlit#2666) Indicate widgets need to have labels (streamlit#2688) Clean up file update calls (streamlit#2597) Revert "🔧 "Run on save" now defaults to true (streamlit#2641)" (streamlit#2694)
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Feb 2, 2021
* develop: Fix svg rendering in st.image() (streamlit#2666) Indicate widgets need to have labels (streamlit#2688) Clean up file update calls (streamlit#2597) Revert "🔧 "Run on save" now defaults to true (streamlit#2641)" (streamlit#2694)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://www.notion.so/streamlit/Always-Rerun-should-be-the-default-09fcc67fa96940a9b9447c18b48003d7:
Background
Changing the source file of a Streamlit app brings this up:
Proposal
DECISION: Change the default on the existing "server.runOnSave" to True.
Users can opt out by setting it to False.