Skip to content

Fix websocket port handling#263

Merged
tvst merged 2 commits intostreamlit:developfrom
jrhone:fix_ws_port
Oct 4, 2019
Merged

Fix websocket port handling#263
tvst merged 2 commits intostreamlit:developfrom
jrhone:fix_ws_port

Conversation

@jrhone
Copy link
Copy Markdown
Contributor

@jrhone jrhone commented Oct 3, 2019

Properly handle parsing the port from window.location

Fixes #250

@jrhone jrhone requested a review from tvst October 3, 2019 23:36
@tvst tvst merged commit 9e4edd3 into streamlit:develop Oct 4, 2019
tvst pushed a commit that referenced this pull request Oct 4, 2019
* handle websocket port differently

* remove streamlit whl
tconkling added a commit to tconkling/streamlit that referenced this pull request Oct 7, 2019
* develop:
  Support cli parameters (streamlit#186)
  Update README.md
  Update README.md (streamlit#282)
  Bug fix: make Streamlit watch files in subfolders again (streamlit#265)
  fix st.code("") (streamlit#272)
  different jslint commands for circleci and not (streamlit#273)
  Batch updates to report elements in the App state (streamlit#194)
  Minor typo in pull_request_template.md (streamlit#262)
  Fix wrong quote used in the provided sample code (streamlit#267)
  Fix websocket port handling (streamlit#263)
  Closing sidebar when clicking outside (streamlit#223)
  Version 0.47.2 (streamlit#212)
  [docs] Changed value in Show progress section of docs/getting_started.md to fix error (Issue streamlit#234) (streamlit#235)
  Update README.md
  Remove checkbox from CLA in PR Template
  Update README.md
  Update README.md
  mapping_demo: catch urllib errors (streamlit#224)
tconkling added a commit to tconkling/streamlit that referenced this pull request Oct 8, 2019
* develop:
  Read config from ${CWD}/.streamlit/config.toml (streamlit#227)
  Fix unsafe_allow_html (streamlit#259)
  Support cli parameters (streamlit#186)
  Update README.md
  Update README.md (streamlit#282)
  Bug fix: make Streamlit watch files in subfolders again (streamlit#265)
  fix st.code("") (streamlit#272)
  different jslint commands for circleci and not (streamlit#273)
  Batch updates to report elements in the App state (streamlit#194)
  Minor typo in pull_request_template.md (streamlit#262)
  Fix wrong quote used in the provided sample code (streamlit#267)
  Fix websocket port handling (streamlit#263)
  Closing sidebar when clicking outside (streamlit#223)
  Version 0.47.2 (streamlit#212)
  [docs] Changed value in Show progress section of docs/getting_started.md to fix error (Issue streamlit#234) (streamlit#235)
  Update README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UriUtil.ts using window.location.port will cause error if port is 80

2 participants