Speed up Cypress tests #2600
Merged
Speed up Cypress tests #2600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
January 13, 2021 22:53
ghost
changed the title
ghost
marked this pull request as ready for review
ghost
self-requested a review
added 2 commits
January 15, 2021 12:20
AnOctopus
suggested changes
Jan 15, 2021
Contributor
AnOctopus
left a comment
AnOctopus
left a comment
There was a problem hiding this comment.
Looks pretty good overall. I have a few small changes/additions that I think would be good but that I'm not entirely sure about.
There's a bunch of added functions that don't have types on them that would be trivial to add, but it doesn't seem like we hard require them so that isn't a blocker.
Author
|
@AnOctopus Thanks for the review, made requested changes. |
AnOctopus
approved these changes
Jan 15, 2021
Author
|
@tconkling Made requested changes. Great, so looks like tests are passing and I've got two approvals. Since it affects everyone, I'll just bring it up one more time at next standup, then merge. |
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Jan 25, 2021
* develop: ✨ Support "auto" as the new default for st.image's `use_column_width` (streamlit#2635) fix branch name in pr-preview (streamlit#2644) ♻️ Remove "_proto" from "exception_proto.py" (streamlit#2638) ♻️ Remove "_proto" from "media_proto.py" and "iframe_proto.py" (streamlit#2639) Refactor: remove "_proto" from "image_proto.py" (streamlit#2626) correct info on url shortening behavior (streamlit#2576) Set "overflow:visible" on st.expander (streamlit#2611) Revert "Revert "Add anchors to Markdown headers (streamlit#2513)"" Fix file uploader docs + change to getvalue (streamlit#2628) Update change log Update notices Up version to 0.75.0 Revert "Add anchors to Markdown headers (streamlit#2513)" Speed up Cypress tests (streamlit#2600) Remove "beta feature" notice on st.color_picker (streamlit#2625) Deflake multiselect snapshot test by waiting for stale-element (streamlit#2624) Rerender Maybe components when they're first disabled (streamlit#2617) Increase side padding to 5rem when app is in wide mode (streamlit#2613)
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speeds up our CircleCI Cypress tests with a few optimizations.
scripts/run_e2e_tests.pyto accommodate thisvenvpreviously not cachingnode_modulesfolder and stop runningyarn installifnode_modulesis already foundscripts/run_e2e_tests.pyto spawn its own React app servercircleci tests split --split-by=timingsResults
start-server-and-testand removedcy:serve-and-run*Yarn tasksFixes #90